Skip to content

Conversation

@amardatar
Copy link
Contributor

Proposed changes

Fixes #373

This adds an additional branch to the entrypoint which checks for AWS_CONTAINER_AUTHORIZATION_FILE (in the same position as this check occurs in awscredentials.js) to prevent the script from failing when using EKS Pod Identities.

Checklist

Before creating a pull request (PR), run through this checklist and mark each as complete:

@github-actions
Copy link

github-actions bot commented Feb 27, 2025

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@amardatar
Copy link
Contributor Author

I have hereby read the F5 CLA and agree to its terms

@amardatar
Copy link
Contributor Author

For reference - I've tested changes by building and running this image in my env.

@luhkevin
Copy link

luhkevin commented Apr 3, 2025

Note - you should also add

env AWS_CONTAINER_CREDENTIALS_FULL_URI;
env AWS_CONTAINER_AUTHORIZATION_TOKEN_FILE;

to common/etc/nginx/nginx.conf in order to preserve these variables for worker threads.
Actually I'm not sure if AWS_CONTAINER_CREDENTIALS_FULL_URI is needed but AWS_CONTAINER_AUTHORIZATION_TOKEN_FILE is at least used when we read credentials via pod identity.

@alessfg alessfg added the bug Something isn't working label Jun 27, 2025
@alessfg alessfg changed the title fix: fixes usage with eks pod identity fix: Fixes usage with eks pod identity Jun 27, 2025
@alessfg alessfg merged commit 2d71c78 into nginx:main Jun 27, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error running pod with EKS Pod Identity

3 participants