feat: use dynamic dns resolution for upstreams in oss like plus #406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Elijah Zupancic <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR unifies the upstream configuration for OSS and Plus by switching both to dynamic DNS reconfiguration, ensuring consistent behavior across both editions.
- Updated the comment in the Plus configuration file to remove specific NGINX Plus references.
- Modified the OSS configuration file to add a dynamic DNS resolution directive with an upstream zone and a "resolve" modifier.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| plus/etc/nginx/templates/upstreams.conf.template | Removed explicit mention of NGINX Plus in favor of unified config. |
| oss/etc/nginx/templates/upstreams.conf.template | Added an upstream zone directive and the "resolve" parameter to enable dynamic DNS reloading. |
Comments suppressed due to low confidence (1)
plus/etc/nginx/templates/upstreams.conf.template:1
- [nitpick] The removal of 'NGINX Plus' from the comment is intended to unify the configurations; please ensure that any documentation referring to Plus still clarifies the differences, if any, between the OSS and Plus deployments.
# This configuration should dynamically reload S3 backends
alessfg
changed the title
dekobon
changed the title
Collaborator
Author
|
recheck |
alessfg
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This change unifies the OSS upstream configuration with the Plus upstream configuration, so that both are using dynamic DNS reconfiguration for upstreams.
Checklist
Before creating a pull request (PR), run through this checklist and mark each as complete:
README.md).