Skip to content

feat: use dynamic dns resolution for upstreams in oss like plus #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025
Merged

feat: use dynamic dns resolution for upstreams in oss like plus #406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions oss/etc/nginx/templates/upstreams.conf.template
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
# This configuration should dynamically reload S3 backends
# as they change in DNS.

# Use NGINX's non-blocking DNS resolution
resolver ${DNS_RESOLVERS};

upstream storage_urls {
# Upstreams are not refreshed until NGINX configuration is reloaded.
# NGINX Plus will dynamically reload upstreams when DNS records are changed.
server ${S3_UPSTREAM};
zone s3_backends 64k;

server ${S3_UPSTREAM} resolve;
}
2 changes: 1 addition & 1 deletion plus/etc/nginx/templates/upstreams.conf.template
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# This configuration with NGINX Plus should dynamically reload S3 backends
# This configuration should dynamically reload S3 backends
# as they change in DNS.

# Use NGINX's non-blocking DNS resolution
Expand Down