Skip to content

Extend timeout for log collection #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2024
Merged

Extend timeout for log collection #43

merged 1 commit into from
Sep 18, 2024

Conversation

dareste
Copy link
Collaborator

@dareste dareste commented Sep 18, 2024

This PR addresses the following changes:

  • collect-pods-logs job timeout is increased to 120 seconds.
  • Warnings are issued in the stdout when one or more jobs fail.

@dareste dareste requested a review from a team as a code owner September 18, 2024 11:10
mrajagopal
mrajagopal approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@mrajagopal mrajagopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mrajagopal mrajagopal merged commit 48a7660 into main Sep 18, 2024
2 checks passed
@dareste dareste deleted the fix-extend-timeouts branch September 25, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrajagopal mrajagopal mrajagopal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dareste @mrajagopal