Coveo: Fix vertical overflow race condition #324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noticed that on hard page refreshes, and slower connections that I would still see the extra vertical overflow caused by coveo. I assumed it was a race condition, and wrapping the removal of `atomic-relevance-inspector` in a timeout, would generally resolve it. I didn't want a timeout to be the "fix" here, so I added the Mutation Observer (https://developer.mozilla.org/en-US/docs/Web/API/MutationObserver) which appears to be the safest approach. There's an overall 5 second timeout still, in case search never renders for whatever reason.
✅ Deploy Preview will be available once build job completes!
|
lamATnginx
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that on hard page refreshes, and slower connections that I would still see the extra vertical overflow caused by coveo. I assumed it was a race condition, and wrapping the removal of
atomic-relevance-inspectorin a timeout, would generally resolve it. I didn't want a timeout to be the "fix" here, so I added the Mutation Observer (https://developer.mozilla.org/en-US/docs/Web/API/MutationObserver) which appears to be the safest approach.There's an overall 5 second timeout still, in case search never renders for whatever reason.
Coveo 😞 .