Skip to content

Fix card icon size + alignment #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 21, 2025
Merged

Fix card icon size + alignment #355

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f00cc5
Card: Fix icon size + add alignment
lamATnginx Aug 20, 2025
4e191f1
Card: Fix issue with icon shrinking
lamATnginx Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions assets/css/v2/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1597,7 +1597,7 @@ a:hover {
display: flex;
flex-direction: row;
gap: 1rem;
align-items: center;
align-items: flex-start;
color: oklch(var(--color-brand));

img.card-brand-icon {
Expand Down Expand Up @@ -1637,6 +1637,7 @@ a:hover {
.card-container {
.card-header {
justify-content: flex-start;
align-items: center;

.lucide,
.card-brand-icon {
Expand Down Expand Up @@ -2161,8 +2162,9 @@ hr {
}

.lucide {
width: 1.8ch;
height: 1.8ch;
flex: 0 0 auto;
width: 1.5rem;
height: 1.5rem;
Comment on lines +2166 to +2167
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not to tackle in this PR but this class is a little scary if we ever want to adjust sizing without affecting potential theme consumers.

It would probably be a good idea to variabilize this with variants (sm, md, lg) but lets cross that bridge when we get there.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future, we can update the lucide partial and icon shortcode to accept new prop and add a data attribute.

stroke: currentColor;
fill: none;
stroke-width: 2;
Expand Down