Skip to content

Conversation

lamATnginx
Copy link
Collaborator

@lamATnginx lamATnginx commented Aug 20, 2025

Proposed changes

Before:
Screenshot 2025-08-20 at 11 10 00 AM
Screenshot 2025-08-20 at 11 09 41 AM

After:
Screenshot 2025-08-20 at 11 32 14 AM
Screenshot 2025-08-20 at 11 32 09 AM

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

@lamATnginx lamATnginx self-assigned this Aug 20, 2025
@lamATnginx lamATnginx requested a review from a team as a code owner August 20, 2025 18:10
@lamATnginx lamATnginx added the bug Something isn't working label Aug 20, 2025
Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-hugo-theme/356/

Copy link
Member

@TasoOneAsia TasoOneAsia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks heaps better now! I think we'll also want to bring the input's font-size down a tad to be closer to the rest of the sidebar but @danielledeleo feel free to overrule me.

IMO the current font-size really makes it standout relatively speaking.

In testing this, I also found that there is currently no way to initiate a search from the home page on mobile viewports (as our homepage does not render a sidebar)

@lamATnginx lamATnginx force-pushed the fix-coveo-sidebar-clip branch from cd32716 to 7d3692b Compare August 21, 2025 19:20
@danielledeleo
Copy link
Contributor

I don't think the font size is the main issue. It's the vertical padding inside the search box.

GitHub:
Screenshot 2025-08-22 at 6 56 02 AM

Stripe Docs:
Screenshot 2025-08-22 at 6 56 29 AM

Google Cloud docs:
Screenshot 2025-08-22 at 6 57 48 AM

@lamATnginx, is it straightforward to reuse the same component for the sidebar and navbar search? If it spawns twice in the DOM, fine, but I think they should be styled together. The navbar search box and the sidebar search aren't quite identical. The navbar one grows when selected now too.

Screen.Recording.2025-08-22.at.7.00.47.AM.mov
Screenshot 2025-08-22 at 7 03 33 AM

@lamATnginx lamATnginx merged commit bf75497 into mainframe Aug 22, 2025
4 checks passed
@lamATnginx lamATnginx deleted the fix-coveo-sidebar-clip branch August 22, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants