generated from nginx/template-repository
-
Notifications
You must be signed in to change notification settings - Fork 5
Layout: sidebar scroll anchor #391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview will be available once build job completes!
|
5e00b70
to
338844a
Compare
❌ One or more of the commit messages in this PR do not match the nginx-hugo-theme git guidelines, please check the CI job for more details on which commits were flagged and why.Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR. |
268f545
to
7fd157b
Compare
4dba16b
to
ea03101
Compare
nginx-jack
reviewed
Sep 10, 2025
95c7f6d
to
dd8410b
Compare
lamATnginx
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR adds functionality to the sidebar that allows it to move to the user's location in the docs on page load or reload. This helps with long lists or nested docs. This is in relevance to issue 578
Here I've got a video showcasing the changes. I navigate to a nested link, click on it and scroll up, then reload the page to show that it navigates back to the link. Then I show how it will try to bring the link to the top if possible.
Screen.Recording.2025-09-09.at.10.45.27.AM.mov
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTING
documentREADME.md
andCHANGELOG.md
)