Skip to content

ProductSelector: Fix nested path resolution #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 10, 2025
Merged

ProductSelector: Fix nested path resolution #394

merged 3 commits into from
Sep 10, 2025

Conversation

TasoOneAsia
Copy link
Member

@TasoOneAsia TasoOneAsia commented Sep 10, 2025 •
edited
Loading

Proposed changes

  • Resolves issues with subpaths resolution for products with a multi-part root path.
  • New RE pattern was tested across current products without issue.

Example Match:

CleanShot 2025-09-10 at 09 37 28

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

@TasoOneAsia
ProductSelector: Fix nested path resolution
49a5959 
Resolves issues with subpaths for nginxaas
@TasoOneAsia TasoOneAsia requested a review from a team as a code owner September 10, 2025 13:36
@github-actions GitHub Actions
Copy link

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-hugo-theme/394/

@TasoOneAsia TasoOneAsia self-assigned this Sep 10, 2025
@danielledeleo danielledeleo mentioned this pull request Sep 10, 2025
Closed
5 tasks
@TasoOneAsia TasoOneAsia merged commit 0bacccd into main Sep 10, 2025
8 checks passed
@TasoOneAsia TasoOneAsia deleted the fix/product-selector-sub-resolution branch September 10, 2025 16:22
maximusmith529 pushed a commit that referenced this pull request Sep 10, 2025
@TasoOneAsia @maximusmith529
ProductSelector: Fix nested path resolution (#394)
35cd5a3 
* ProductSelector: Fix nested path resolution

* ExampleSite: Add nested product test case

* ProductSelector: Normalize path for preview environments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nginx-jack nginx-jack nginx-jack approved these changes

@lamATnginx lamATnginx lamATnginx approved these changes

Assignees

@TasoOneAsia TasoOneAsia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TasoOneAsia @nginx-jack @lamATnginx