Skip to content

Set coveo usage via flag #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 16, 2025
Merged

Set coveo usage via flag #424

merged 6 commits into from
Oct 16, 2025

Conversation

lamATnginx
Copy link
Collaborator

@lamATnginx lamATnginx commented Oct 15, 2025 •
edited
Loading

Proposed changes

Add a flag via params to enable Coveo usage.

  1. The flag will control the entry for Coveo via our scripts + styles.
  2. Add a error page to the search.html page. See below:
Screenshot 2025-10-15 at 2 20 31 PM

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

@lamATnginx lamATnginx self-assigned this Oct 15, 2025
@lamATnginx lamATnginx requested a review from a team as a code owner October 15, 2025 20:54
@lamATnginx lamATnginx added the enhancement New feature or request label Oct 15, 2025
@github-actions GitHub Actions
Copy link

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-hugo-theme/424/

@lamATnginx lamATnginx mentioned this pull request Oct 15, 2025
Closed
5 tasks
danielledeleo
danielledeleo reviewed Oct 15, 2025
View reviewed changes
TasoOneAsia
TasoOneAsia approved these changes Oct 16, 2025
View reviewed changes
Copy link
Member

@TasoOneAsia TasoOneAsia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A small nit for improved readability and an unrelated CSP observation.

@lamATnginx lamATnginx merged commit 520e7cc into main Oct 16, 2025
7 checks passed
@lamATnginx lamATnginx deleted the add/flag-enable-coveo branch October 16, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielledeleo danielledeleo danielledeleo approved these changes

@TasoOneAsia TasoOneAsia TasoOneAsia approved these changes

Assignees

@lamATnginx lamATnginx

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lamATnginx @danielledeleo @TasoOneAsia