Skip to content

Conversation

lamATnginx
Copy link
Collaborator

@lamATnginx lamATnginx commented Oct 16, 2025

Proposed changes

  • Added new partial to handle "feature flag"-like hugo params for Coveo + Qualtrics for example.
  • Refactored old flag check for Coveo and Qualtrics.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

@lamATnginx lamATnginx self-assigned this Oct 16, 2025
@lamATnginx lamATnginx requested a review from a team as a code owner October 16, 2025 19:53
@lamATnginx lamATnginx added the enhancement New feature or request label Oct 16, 2025
Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-hugo-theme/425/

@nginx-jack
Copy link
Collaborator

Could you do a build of the documentation repo with --templateMetrics enabled, and see if there's any major build time impacts?
Thinking about it, we should add a little performance check to our builds, in case we add a new shortcode that ends up really slowing the build time.

@nginx-jack
Copy link
Collaborator

Also worth adding a "how to" for feature flags to the example site itself.

Feel free to do that in another PR, I've approved, so resolve and merge these comments if you need.

@lamATnginx
Copy link
Collaborator Author

Could you do a build of the documentation repo with --templateMetrics enabled, and see if there's any major build time impacts? Thinking about it, we should add a little performance check to our builds, in case we add a new shortcode that ends up really slowing the build time.

We have lighthouse in our pipeline.

@lamATnginx lamATnginx merged commit fd921f2 into main Oct 17, 2025
7 checks passed
@lamATnginx lamATnginx deleted the add/ff-partial branch October 17, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants