Skip to content

Fix coveo filtering clearing in URL on refresh #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 17, 2025
Merged

Fix coveo filtering clearing in URL on refresh #428

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ece7791
Coveo: Fix filtering clearing in URL on refresh
lamATnginx Oct 17, 2025
e9f8681
Coveo: Removed redundant code
lamATnginx Oct 17, 2025
5aaf159
Coveo: Revert to atomic external instead of standalone
lamATnginx Oct 17, 2025
39370ff
Coveo: Add styling
lamATnginx Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion assets/js/coveo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,9 @@ async function atomicCoveo() {
return request;
},
});
await el.executeFirstSearch();

// No standalone searchboxes should be getting executing first search.
if (el.id === 'search-v2') await el.executeFirstSearch();
});

const headerSearchBar = document.querySelector('#search-standalone-header');
Expand Down
4 changes: 2 additions & 2 deletions layouts/partials/coveo-atomic-search.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{{ $redirectionUrl := .redirectionUrl | default .Site.Params.coveo_search_redirect | default "/search.html" }}
{{ $id := .id | default "search-standalone-header"}}
<atomic-search-interface id={{ $id }}>
<atomic-search-box redirection-url={{ $redirectionUrl }} class="header-search-box">
</atomic-search-box>
<atomic-search-box redirection-url={{ $redirectionUrl }} class="header-search-box">
</atomic-search-box>
</atomic-search-interface>
10 changes: 4 additions & 6 deletions layouts/partials/header.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@
</label>
{{ end }}
<div class="header__search" data-testid="header__search">
<!-- Standalone search box. -->
{{ partial "coveo-atomic-search.html" (dict "id" "search-standalone-header") }}
<!-- Standalone search box. -->
{{ partial "coveo-atomic-search.html" (dict "id" "search-standalone-header") }}
</div>
{{ end }}
</div>
Expand All @@ -35,10 +35,8 @@

</div>
<div class="header-search-dropdown" data-testid="header-search-dropdown-mobile">
<atomic-external selector="#search-standalone-header">
{{ $redirectUrl := default .Site.Params.coveo_search_redirect "/search.html" }}
<atomic-search-box redirection-url={{ $redirectUrl }}></atomic-search-box>
</atomic-external>
<!-- Standalone search box. -->
{{ partial "coveo-atomic-search.html" (dict "id" "search-standalone-header-dropdown") }}
</div>
</div>
{{ end }}
Loading