Error log verbosity enhanced #111
Open
+23
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
route443
requested changes
Aug 14, 2025
There was a problem hiding this comment.
You are accessing headers by index using the original casing, so the case matters here. See https://nginx.org/en/docs/njs/reference.html#r_headers_in
| @@ -131,21 +131,21 @@ function validateIdTokenClaims(r, claims) { | |||
| const missingClaims = requiredClaims.filter((claim) => !claims[claim]); | |||
|
|
|||
| if (missingClaims.length > 0) { | |||
| r.error(`OIDC ID Token validation error: missing claim(s) ${missingClaims.join(' ')}`); | |||
| r.error(`OIDC ID Token validation error for " + r.headersIn['host'] + r.uri + ": missing claim(s) ${missingClaims.join(' ')}`); | |||
There was a problem hiding this comment.
Looks like a copy-paste error, and r.headersIn will be logged as a literal.
| return false; | ||
| } | ||
|
|
||
| // Audience must include the configured client | ||
| const aud = Array.isArray(claims.aud) ? claims.aud : claims.aud.split(','); | ||
| if (!aud.includes(r.variables.oidc_client)) { | ||
| r.error(`OIDC ID Token validation error: aud claim (${claims.aud}) ` + | ||
| r.error(`OIDC ID Token validation error for " + r.headersIn['host'] + r.uri + ": aud claim (${claims.aud}) ` + |
There was a problem hiding this comment.
Same thing here, it will be logged as a literal.
| @@ -160,12 +160,12 @@ function validateIdTokenClaims(r, claims) { | |||
| : ''; | |||
|
|
|||
| if (claims.nonce !== clientNonceHash) { | |||
| r.error(`OIDC ID Token validation error: nonce from token (${claims.nonce}) ` + | |||
| r.error(`OIDC ID Token validation error for " + r.headersIn['host'] + r.uri + ": nonce from token (${claims.nonce}) ` + | |||
There was a problem hiding this comment.
it will be logged as a literal
| if (tokenset.error) { | ||
| r.error("OIDC " + tokenset.error + " " + tokenset.error_description); | ||
| r.error("OIDC for " + r.headersIn['host'] + r.uri + " " + tokenset.error + " " + tokenset.error_description); |
There was a problem hiding this comment.
looks like the word "error" is missing
| @@ -373,7 +373,7 @@ async function handleFrontChannelLogout(r) { | |||
|
|
|||
| const claims = await getTokenClaims(r, sessionJwt); | |||
| if (claims.iss !== requestIss) { | |||
| r.error("Issuer mismatch during logout. Received iss: " + | |||
| r.error("Issuer mismatch during logout for " + r.headersIn['host'] + r.uri + " Received iss: " + | |||
| `does not match client (${clientNonceHash})`); | ||
| return false; | ||
| } | ||
| } else if (isNewSession(r)) { | ||
| r.error("OIDC ID Token validation error: " + | ||
| r.error("OIDC ID Token validation error for " + r.headersIn['host'] + r.uri + ": " + |
There was a problem hiding this comment.
There is an extra concatenation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added HTTP Host and URI to all error logs