fix(release): change ngDevMode to isDevMode()#188
Merged
NetanelBasal merged 1 commit intongneat:masterfrom Aug 21, 2025
Merged
Conversation
Angular best practice for checking dev mode, without conflicting global that doesn't pass Typescript's lib check. Resolves ngneat#186, resolves ngneat#178
|
|
This was referenced Aug 20, 2025
Closed
alexsukhodolsky
approved these changes
Aug 21, 2025
Collaborator
|
Angular does not declare best practices on using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Angular best practice for checking dev mode, without conflicting global that doesn't pass Typescript's lib check.
Resolves #186, resolves #178
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently
ngDevModeis declared as a global const with a signature that doesn't match the same global const exported by Angular. This results in TypeScript errors whentsconfig.json::compilerOptions.skipLibCheckis set to false.Issue Number: N/A
What is the new behavior?
Instead of using
ngDevMode, we use Angular'sisDevMode()function to determine dev mode status, then take identical action as before.Does this PR introduce a breaking change?
Other information