Enhance image slider with multiple file upload support#209
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the image slider component by adding comprehensive file upload support and improving dynamic styling. The changes modernize the image upload workflow and refactor component styling.
- Import syntax changed from object destructuring to direct default imports for es-toolkit utilities
- Added new image upload dialog with support for multiple file uploads and media browser integration
- Refactored image slider component styling and pagination control for better responsiveness
Reviewed Changes
Copilot reviewed 29 out of 30 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/vehicle-status-card.ts | Updated import syntax for isEmpty from es-toolkit |
| src/utils/lovelace/stub-config.ts | Removed unused default configuration properties |
| src/utils/lovelace/create-card-element.ts | Added picture card loading utilities and helper functions |
| src/utils/loader.ts | Removed stickyPreview function |
| src/utils/helpers-dom.ts | Added picture upload and quick bar utility functions |
| src/utils/editor/show-dialog-box.ts | Updated showAlertDialog to accept TemplateResult |
| src/utils/editor/menu-element.ts | Removed unnecessary wrapper divs and updated CSS selectors |
| src/utils/editor/create.ts | Added fallback value for CSS variable |
| src/utils/editor/clean-config.ts | Updated import syntax for isEmpty |
| src/utils/base-button.ts | Updated import syntax for pick |
| src/types/config/card/layout.ts | Exported ImagesSwipeConfig interface |
| src/types/config/card/card-config.ts | Removed empty line |
| src/ha/panels/lovelace/toast.ts | Added toast notification functionality |
| src/ha/index.ts | Added dialogs/elements export |
| src/ha/dialogs/image-upload/vsc-image-upload.ts | Created comprehensive image upload dialog component |
| src/ha/dialogs/image-upload/show-image-upload.ts | Added image upload dialog helper function |
| src/ha/dialogs/form/vsc-dialog-form.ts | Removed unused imports and helper functions |
| src/ha/dialogs/elements.ts | Added HaPictureUpload interface |
| src/editor/editor.ts | Added picture card loading on editor connection |
| src/editor/editor-const.ts | Added HA_PICTURE_UPLOAD element constant |
| src/editor/components/slide-images/panel-images-preview.ts | Replaced vsc-image-item with direct img elements |
| src/editor/components/slide-images/panel-images-editor.ts | Updated to use new image upload dialog |
| src/editor/components/slide-images/index.ts | Removed all exports |
| src/editor/components/button-card/panel-button-card-main.ts | Updated imports and added null assertion operators |
| src/editor/base-editor.ts | Added toast functionality and updated imports |
| src/components/vsc-images-slide.ts | Refactored styling and pagination logic |
| src/components/shared/vsc-default-card.ts | Updated import syntax for isEmpty |
| rollup.config.js | Simplified build configuration |
| package.json | Updated dependencies and added dev script |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ngocjohn
added a commit
that referenced
this pull request
Oct 20, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Oct 20, 2025
## [1.18.0](v1.17.0...v1.18.0) (2025-10-20) ### Features * **images:** enhance image slider with multiple file upload support ([#209](#209)) ([eee496b](eee496b)) ### Bug Fixes * **button:** Update button grid legacy checks and update migration logic ([#213](#213)) ([93be63d](93be63d)) * ensure swiper usage defaults to false and remove debug logs in color utility ([a67f2ae](a67f2ae)) * icon action handler method ([#207](#207)) ([76e2e09](76e2e09)) * Import of leaflet-providers ([#205](#205)) ([963a62d](963a62d))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve the image slider functionality by adding dynamic styles and pagination control, while also updating the image upload method to handle multiple files.