Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #779 +/- ##
==========================================
- Coverage 50.61% 50.52% -0.09%
==========================================
Files 101 101
Lines 11204 11204
==========================================
- Hits 5671 5661 -10
- Misses 5116 5122 +6
- Partials 417 421 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
URI vs URL inconsistency
RFC 3986 Semantics:
URL = Has scheme + provides location AND access method (can be "dialed")
URI = General identifier (superset of URL)
All URLs are URIs, but not all URIs are URLs
ngrok API Conventions:
url → Network addresses (public endpoints, upstream addresses)
uri → API resource references (e.g., /endpoints/ep_xxx)
How
Breaking Changes
Rename BoundEndpoint.spec.endpointURI → BoundEndpoint.spec.endpointURL