Skip to content

URI vs URL inconsistency#779

Open
sabrina-ngrok wants to merge 1 commit intomainfrom
sabrina/url-uri-inconsistency
Open

URI vs URL inconsistency#779
sabrina-ngrok wants to merge 1 commit intomainfrom
sabrina/url-uri-inconsistency

Conversation

@sabrina-ngrok
Copy link
Contributor

What

URI vs URL inconsistency

RFC 3986 Semantics:
URL = Has scheme + provides location AND access method (can be "dialed")
URI = General identifier (superset of URL)
All URLs are URIs, but not all URIs are URLs

ngrok API Conventions:
url → Network addresses (public endpoints, upstream addresses)
uri → API resource references (e.g., /endpoints/ep_xxx)

How

  1. Rename BoundEndpoint.spec.endpointURI → endpointURL in the Go types
  2. Update the kubebuilder printcolumn from URI to URL
  3. Regenerate CRDs with make manifests
  4. Document the breaking change in 1.0 release notes

Breaking Changes

Rename BoundEndpoint.spec.endpointURI → BoundEndpoint.spec.endpointURL

@sabrina-ngrok sabrina-ngrok requested a review from a team as a code owner March 12, 2026 16:33
@github-actions github-actions bot added area/controller Issues dealing with the controller area/helm-chart Issues dealing with the helm chart size/L Denotes a PR that changes 100-499 lines labels Mar 12, 2026
@codecov
Copy link

codecov bot commented Mar 12, 2026

Codecov Report

❌ Patch coverage is 60.46512% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.52%. Comparing base (e1eb91a) to head (4a17c80).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ternal/controller/bindings/boundendpoint_poller.go 67.85% 9 Missing ⚠️
...al/controller/bindings/boundendpoint_controller.go 42.85% 4 Missing ⚠️
...ternal/controller/bindings/forwarder_controller.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #779      +/-   ##
==========================================
- Coverage   50.61%   50.52%   -0.09%     
==========================================
  Files         101      101              
  Lines       11204    11204              
==========================================
- Hits         5671     5661      -10     
- Misses       5116     5122       +6     
- Partials      417      421       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/controller Issues dealing with the controller area/helm-chart Issues dealing with the helm chart size/L Denotes a PR that changes 100-499 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant