chore: migrate eslint config to flat format #4887
+1,585
−894
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,110 @@ | ||
| import { FlatCompat } from '@eslint/eslintrc'; | ||
| import { dirname } from 'path'; | ||
| import { fileURLToPath } from 'url'; | ||
| import js from '@eslint/js'; | ||
| import nxEslintPlugin from '@nx/eslint-plugin'; | ||
|
|
||
| const compat = new FlatCompat({ | ||
| baseDirectory: dirname(fileURLToPath(import.meta.url)), | ||
| recommendedConfig: js.configs.recommended, | ||
| }); | ||
|
|
||
| export default [ | ||
| { | ||
| ignores: ['**/dist'], | ||
| }, | ||
| { plugins: { '@nx': nxEslintPlugin } }, | ||
| { | ||
| files: ['**/*.ts', '**/*.tsx', '**/*.js', '**/*.jsx'], | ||
| rules: { | ||
| '@nx/enforce-module-boundaries': [ | ||
| 'error', | ||
| { | ||
| allow: [], | ||
| depConstraints: [ | ||
| { | ||
| sourceTag: '*', | ||
| onlyDependOnLibsWithTags: ['*'], | ||
| }, | ||
| ], | ||
| }, | ||
| ], | ||
| '@typescript-eslint/member-ordering': 'off', | ||
| '@typescript-eslint/no-inferrable-types': 'warn', | ||
| }, | ||
| }, | ||
| ...compat | ||
| .config({ | ||
| extends: ['plugin:@nx/typescript'], | ||
| }) | ||
| .map((config) => ({ | ||
| ...config, | ||
| files: ['**/*.ts', '**/*.tsx', '**/*.cts', '**/*.mts'], | ||
| rules: { | ||
| ...config.rules, | ||
| 'no-extra-semi': 'off', | ||
| }, | ||
| })), | ||
| ...compat | ||
| .config({ | ||
| extends: ['plugin:@nx/javascript'], | ||
| }) | ||
| .map((config) => ({ | ||
| ...config, | ||
| files: ['**/*.js', '**/*.jsx', '**/*.cjs', '**/*.mjs'], | ||
| rules: { | ||
| ...config.rules, | ||
| 'no-extra-semi': 'off', | ||
| }, | ||
| })), | ||
| ...compat | ||
| .config({ | ||
| plugins: ['eslint-plugin-import', '@typescript-eslint'], | ||
| }) | ||
| .map((config) => ({ | ||
| ...config, | ||
| files: ['**/*.ts'], | ||
| rules: { | ||
| ...config.rules, | ||
| '@typescript-eslint/no-explicit-any': 'off', | ||
| '@typescript-eslint/no-unused-vars': [ | ||
| 'warn', | ||
| { | ||
| argsIgnorePattern: '^_', | ||
| varsIgnorePattern: '^_', | ||
| caughtErrorsIgnorePattern: '^_', | ||
| }, | ||
| ], | ||
| '@typescript-eslint/naming-convention': 'off', | ||
| '@typescript-eslint/prefer-namespace-keyword': 'error', | ||
| '@typescript-eslint/no-empty-function': 'warn', | ||
| '@typescript-eslint/no-empty-object-type': 'warn', | ||
| eqeqeq: ['off', 'smart'], | ||
| 'id-blacklist': [ | ||
| 'error', | ||
| 'any', | ||
| 'Number', | ||
| 'number', | ||
| 'String', | ||
| 'string', | ||
| 'Boolean', | ||
| 'boolean', | ||
| 'Undefined', | ||
| 'undefined', | ||
| ], | ||
| 'id-match': 'error', | ||
| 'no-eval': 'off', | ||
| 'no-redeclare': 'off', | ||
| 'no-underscore-dangle': 'off', | ||
| 'no-var': 'error', | ||
| 'no-prototype-builtins': 'off', | ||
| '@typescript-eslint/no-wrapper-object-types': 'off', | ||
| '@typescript-eslint/no-unsafe-function-type': 'off', | ||
| }, | ||
| })), | ||
| { | ||
| files: ['**/*.html'], | ||
| // Override or add rules here | ||
| rules: {}, | ||
| }, | ||
| ]; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| import { FlatCompat } from '@eslint/eslintrc'; | ||
| import { dirname } from 'path'; | ||
| import { fileURLToPath } from 'url'; | ||
| import js from '@eslint/js'; | ||
| import baseConfig from '../../eslint.config.mjs'; | ||
|
|
||
| const compat = new FlatCompat({ | ||
| baseDirectory: dirname(fileURLToPath(import.meta.url)), | ||
| recommendedConfig: js.configs.recommended, | ||
| }); | ||
|
|
||
| export default [ | ||
| { | ||
| ignores: ['**/dist', '**/jest.config.ts', '**/schematics-core/test-setup.ts', '**/schematics-core/utility/standalone.ts'], | ||
|
There was a problem hiding this comment. Is it possible to add this to the base config and remove it in the module specific configs? In the base config: ignores: ['**/dist', '**/jest.config.ts', '**/schematics-core'],I don't remember why we excluded these, this can be looked into later. There was a problem hiding this comment. All the exclusions were added to match previous files. The lints fail without them. There was a problem hiding this comment. Potential option is to add In base config, could add an overrides array like this: overrides: [
{
files: ['**/jest.config.ts'],
env: { node: true },
rules: {
// customize rules for config files
},
},
{
files: ['**/schematics-core/**/*.ts'],
env: { node: true },
rules: {
// loosen rules or add globals as needed
},
},
],Typically, files are ignored if they use "globals" or unusual patterns that could break if linted. Code that uses TypeScript AST, Node.js (node vs web environments), and schematics is also typically ignored. That standalone utility looks a stop-gap or bridge file and may be something that could potentially be removed as There was a problem hiding this comment. It's fine, we don't need to add a eslintignore - AFAIK this isn't supported anymore. |
||
| }, | ||
| ...baseConfig, | ||
| ...compat | ||
| .config({ | ||
| extends: [ | ||
| 'plugin:@nx/angular', | ||
| 'plugin:@angular-eslint/template/process-inline-templates', | ||
| ], | ||
| plugins: ['@typescript-eslint'], | ||
| }) | ||
| .map((config) => ({ | ||
| ...config, | ||
| files: ['**/*.ts'], | ||
| rules: { | ||
| ...config.rules, | ||
| '@angular-eslint/directive-selector': 'off', | ||
| '@angular-eslint/component-selector': 'off', | ||
| '@angular-eslint/prefer-standalone': 'off', | ||
| }, | ||
| languageOptions: { | ||
| parserOptions: { | ||
| project: ['modules/component-store/tsconfig.*.json'], | ||
| }, | ||
| }, | ||
| })), | ||
| ...compat | ||
| .config({ | ||
| extends: ['plugin:@nx/angular-template'], | ||
| }) | ||
| .map((config) => ({ | ||
| ...config, | ||
| files: ['**/*.html'], | ||
| rules: { | ||
| ...config.rules, | ||
| }, | ||
| })), | ||
| { | ||
| ignores: ['schematics-core'], | ||
| }, | ||
| ]; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| import { FlatCompat } from '@eslint/eslintrc'; | ||
| import { dirname } from 'path'; | ||
| import { fileURLToPath } from 'url'; | ||
| import js from '@eslint/js'; | ||
| import baseConfig from '../../eslint.config.mjs'; | ||
|
|
||
| const compat = new FlatCompat({ | ||
| baseDirectory: dirname(fileURLToPath(import.meta.url)), | ||
| recommendedConfig: js.configs.recommended, | ||
| }); | ||
|
|
||
| export default [ | ||
| { | ||
| ignores: ['**/dist', '**/jest.config.ts', '**/schematics-core/test-setup.ts', '**/schematics-core/utility/standalone.ts'], | ||
| }, | ||
| ...baseConfig, | ||
| ...compat | ||
| .config({ | ||
| extends: [ | ||
| 'plugin:@nx/angular', | ||
| 'plugin:@angular-eslint/template/process-inline-templates', | ||
| ], | ||
| plugins: ['@typescript-eslint'], | ||
| }) | ||
| .map((config) => ({ | ||
| ...config, | ||
| files: ['**/*.ts'], | ||
| rules: { | ||
| ...config.rules, | ||
| '@angular-eslint/directive-selector': 'off', | ||
| '@angular-eslint/component-selector': 'off', | ||
| '@angular-eslint/no-input-rename': 'off', | ||
| '@angular-eslint/prefer-standalone': 'off', | ||
| }, | ||
| languageOptions: { | ||
| parserOptions: { | ||
| project: ['modules/component/tsconfig.*.json'], | ||
| }, | ||
| }, | ||
| })), | ||
| ...compat | ||
| .config({ | ||
| extends: ['plugin:@nx/angular-template'], | ||
| }) | ||
| .map((config) => ({ | ||
| ...config, | ||
| files: ['**/*.html'], | ||
| rules: { | ||
| ...config.rules, | ||
| }, | ||
| })), | ||
| { | ||
| ignores: ['schematics-core'], | ||
| }, | ||
| ]; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.