Skip to content

Conversation

timdeschryver
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Partly #4805

What is the new behavior?

Removes unused dependencies.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Copy link

netlify bot commented Jul 19, 2025

Deploy Preview for ngrx-io ready!

Name Link
🔨 Latest commit 89ed21f
🔍 Latest deploy log https://app.netlify.com/projects/ngrx-io/deploys/6893c43c1b4bae0008fca4e2
😎 Deploy Preview https://deploy-preview-4891--ngrx-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Jul 19, 2025

Deploy Preview for ngrx-site-v19 ready!

Name Link
🔨 Latest commit 89ed21f
🔍 Latest deploy log https://app.netlify.com/projects/ngrx-site-v19/deploys/6893c43cc0bf810008689758
😎 Deploy Preview https://deploy-preview-4891--ngrx-site-v19.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@timdeschryver
Copy link
Member Author

I'm trying to figure out why the build is failing on Netlify's side. It seems to work on my machine 😅

@timdeschryver
Copy link
Member Author

I'm trying to figure out why the build is failing on Netlify's side. It seems to work on my machine 😅

This is resolved by increasing the memory in the CI 🙃

package.json Outdated
@@ -189,7 +165,6 @@
"jest-environment-jsdom": "29.7.0",
"jest-jasmine2": "29.7.0",
"jest-preset-angular": "14.4.2",
"jiti": "2.4.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jiti is needed by Vite

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I re-added the dependency.
But shouldn't it raise an error while building/testing the codebase?

@markostanimirovic markostanimirovic merged commit 527383b into main Aug 6, 2025
14 checks passed
@markostanimirovic markostanimirovic deleted the chore/remove-deps branch August 6, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants