-
-
Notifications
You must be signed in to change notification settings - Fork 2k
chore: remove unused dependencies #4891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for ngrx-io ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for ngrx-site-v19 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
afa1c73
to
9e6867f
Compare
9e6867f
to
f278193
Compare
I'm trying to figure out why the build is failing on Netlify's side. It seems to work on my machine 😅 |
This is resolved by increasing the memory in the CI 🙃 |
package.json
Outdated
@@ -189,7 +165,6 @@ | |||
"jest-environment-jsdom": "29.7.0", | |||
"jest-jasmine2": "29.7.0", | |||
"jest-preset-angular": "14.4.2", | |||
"jiti": "2.4.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jiti is needed by Vite
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I re-added the dependency.
But shouldn't it raise an error while building/testing the codebase?
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Partly #4805
What is the new behavior?
Removes unused dependencies.
Does this PR introduce a breaking change?
Other information