Skip to content

fix(www): Make Guide Pages Responsive #4817 #4900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

DuskoPeric
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Guide pages are not responsive

Closes #4817

What is the new behavior?

Guide pages are responsive

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Copy link

netlify bot commented Jul 26, 2025

Deploy Preview for ngrx-io ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 57bcd37
🔍 Latest deploy log https://app.netlify.com/projects/ngrx-io/deploys/689762598220da00081c951c
😎 Deploy Preview https://deploy-preview-4900--ngrx-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Jul 26, 2025

Deploy Preview for ngrx-site-v19 ready!

Name Link
🔨 Latest commit 57bcd37
🔍 Latest deploy log https://app.netlify.com/projects/ngrx-site-v19/deploys/689762595d517b00085ef564
😎 Deploy Preview https://deploy-preview-4900--ngrx-site-v19.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already way better, thanks @DuskoPeric !
What do you think about removing the ToC?
I don't think it adds much value, and it's currently broken on mobile - while I click on an item it doesn't take me to the content.

Image

I also think this PR resolved #4890

@DuskoPeric
Copy link
Contributor Author

Hi @timdeschryver
I think the ToC is broken on large screens as well. Maybe we can create a new issue to fix the ToC functionality.

@timdeschryver
Copy link
Member

@DuskoPeric 😲 you're right!
I will create a new issue to take a look into this behavior.
Removing the ToC for mobile can be done in this PR, or would you rather keep the ToC?

@markostanimirovic markostanimirovic added the Needs Cleanup Review changes needed label Aug 6, 2025
@DuskoPeric
Copy link
Contributor Author

Hi @timdeschryver , based on Marko's suggestion, I created a dropdown for the ToC on mobile screens.

@timdeschryver
Copy link
Member

@DuskoPeric that's a great idea, thanks!
I will go over it tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Cleanup Review changes needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Docs] Make Guide Pages Responsive
3 participants