fix(component): use setTimeout instead of requestAnimationFrame for server and zoneless #4912
+83
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ngrx-io ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
markostanimirovic
requested changes
Aug 5, 2025
There was a problem hiding this comment.
Thanks for the PR @JelleBruisten! See the requested changes below.
It's also necessary to add a unit test and verify the fix.
JelleBruisten
force-pushed
the
master
branch
2 times, most recently
from
497c3d1 to
e9223ec
Compare
|
@JelleBruisten target branch has to be |
✅ Deploy Preview for ngrx-site-v19 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
JelleBruisten
force-pushed
the
master
branch
2 times, most recently
from
f64349d to
ec58077
Compare
…erver and zoneless requestAnimationFrame is not available in server-side contexts and will cause errors. Using setTimeout ensures compatibility across all environments.
|
@markostanimirovic I rebased the branch from the main branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…stead of requestAnimationFrame
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When using either ngrxLet or ngrxPush in ssr and zoneless, the server calls
requestAnimationFramewhich does not exist in a node environment.Closes #4902
What is the new behavior?
Within a node environment ( ssr ) and zoneless we use setTimeout instead of requestAnimationFrame.
Does this PR introduce a breaking change?
Other information
I did some more testing on angular v20, when using ssr + zoneless and using a
NoopTickSchedulerit does trigger changes. I opted for not removing theNoopTickSchedulerand making big changes since@ngrx/componentis in maintenance mode.