feat(control-error): accept control name#588
feat(control-error): accept control name#588RobbyRabbitman wants to merge 4 commits intongxtension:mainfrom
Conversation
| ); | ||
| }); | ||
|
|
||
| it('should resolve a control by its name', () => { |
There was a problem hiding this comment.
Hi @RobbyRabbitman
Can we add one more test with nested form group?
There was a problem hiding this comment.
yes, do u know if the Token ControlContainer can be used to inject the parent control directive? From the source code it seems like those directives provide themselves see e.g. https://github.com/angular/angular/blob/f80b51a738ebccf5f280c50db85d0e250191a2a1/packages/forms/src/directives/reactive_directives/form_group_name.ts#L33C1-L36C3
RobbyRabbitman
force-pushed
the
feat/Allow-NgxControlError-accept-control-name-instead-of-instance
branch
from
0f1bb26 to
3795917
Compare
|
@RobbyRabbitman |
|
Hey! I’d really like to start using this utility in this way. If the only blocker is that it needs to be rebased, I’m happy to take care of that. If there’s no response, I’ll go ahead and do it in the next few days. |
3 participants
#267