fix(NgxControlValueAccessor): notify control synchronously

[RobbyRabbitman]

notifying the control should happen synchronously - fixes #604

[gemini-code-assist]

Summary of Changes

Hello @RobbyRabbitman, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the NgxControlValueAccessor to ensure that value and disabled state changes are synchronously propagated to the associated NgControl. By transitioning from Angular effects to an RxJS-based approach utilizing toObservable, filter, and tap operators, the update mechanism becomes more predictable and immediate, resolving potential timing issues and improving the reliability of form control interactions.

Highlights

• Synchronous CVA Notification: The primary goal of this pull request is to ensure that the NgxControlValueAccessor notifies its associated NgControl synchronously when its value or disabled state changes, addressing a potential bug (fixes [BUG] Race condition with updateOn: 'blur' when setting value and calling markAsTouched in the blur event handler (NgxControlValueAccessor) #604).
• Refactor from effect to RxJS: The internal notification mechanisms (notifyNgControlOnValueChanges and notifyNgControlOnDisabledChanges) have been refactored from using Angular effects to an RxJS-based approach. This now utilizes toObservable with filter, tap, and takeUntilDestroyed operators for more controlled and synchronous execution.
• Dependency Updates: Imports for effect were removed from @angular/core, while takeUntilDestroyed was added from @angular/core/rxjs-interop, and filter and tap were added from rxjs to support the new implementation.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly addresses the asynchronous nature of Angular's effect by replacing it with toObservable().subscribe() to ensure synchronous notifications to the NgControl. This change aligns with the goal of the pull request. The use of takeUntilDestroyed is also a good practice for managing subscriptions and preventing memory leaks. I have one suggestion to improve the consistency of the implementation.