-
Notifications
You must be signed in to change notification settings - Fork 31
Common cache serializer and json serializer #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
fredericDelaporte
merged 6 commits into
nhibernate:master
from
maca88:CommonCacheSerializer
Dec 6, 2018
Merged
Common cache serializer and json serializer #50
fredericDelaporte
merged 6 commits into
nhibernate:master
from
maca88:CommonCacheSerializer
Dec 6, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Util/NHibernate.Caches.Util.JsonSerializer.Tests/JsonCacheSerializerFixture.cs
Outdated
Show resolved
Hide resolved
Util/NHibernate.Caches.Util.JsonSerializer/NHibernate.Caches.Util.JsonSerializer.csproj
Outdated
Show resolved
Hide resolved
Util/NHibernate.Caches.Util.JsonSerializer/NHibernate.Caches.Util.JsonSerializer.csproj
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…and removed test for checking the json output
c4332b9
to
278a786
Compare
I have rebased this. The only updates required for compiling were unrelated obsolete fixes. Had you in mind other changes to do? |
And some cleanup
278a786
to
8555759
Compare
Yes there are some |
Done all the changes that I planned to do. |
fredericDelaporte
approved these changes
Dec 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new shared library
NHibernate.Cache.Common
, proposed by @fredericDelaporte which allows to share the newICacheSerializer
interface among distributed cache providers and also adds aNHibernate.Caches.Util.JsonSerializer
library containing a json serializer by using Json.NET.I've tested the json serializer with the NHiberante tests successfully (master branch), by configuring the serializer as:
TODO:
NHibernate 5.2
release and update the code