Simplify LINQ query by dropping explicit .Where() calls (#571)

+semver:patch

Author: deepsource-autofix[bot]

src/FluentNHibernate.Testing/ConventionsTests/ApplyingToModel/ComponentConventionTests.cs

@@ -79,7 +79,7 @@ private void VerifyModel(Action<ComponentMapping> modelVerification)
             var modelInstance = (ComponentMapping)generatedModels
                 .First(x => x.Classes.FirstOrDefault(c => c.Type == typeof(PropertyTarget)) != null)
                 .Classes.First()
-                .Components.Where(x => x is ComponentMapping).First();
+                .Components.First(x => x is ComponentMapping);
 
             modelVerification(modelInstance);
         }

src/FluentNHibernate.Testing/ConventionsTests/ApplyingToModel/DynamicComponentConventionTests.cs

@@ -85,7 +85,7 @@ private void VerifyModel(Action<ComponentMapping> modelVerification)
             var modelInstance = (ComponentMapping)generatedModels
                 .First(x => x.Classes.FirstOrDefault(c => c.Type == typeof(PropertyTarget)) != null)
                 .Classes.First()
-                .Components.Where(x => x is ComponentMapping).First();
+                .Components.First(x => x is ComponentMapping);
 
             modelVerification(modelInstance);
         }

src/FluentNHibernate.Testing/ConventionsTests/OverridingFluentInterface/ComponentConventionTests.cs

@@ -99,7 +99,7 @@ private void VerifyModel(Action<ComponentMapping> modelVerification)
             var modelInstance = (ComponentMapping)generatedModels
                 .First(x => x.Classes.FirstOrDefault(c => c.Type == mappingType) != null)
                 .Classes.First()
-                .Components.Where(x => x is ComponentMapping).First();
+                .Components.First(x => x is ComponentMapping);
 
             modelVerification(modelInstance);
         }

src/FluentNHibernate.Testing/FluentInterfaceTests/ManyToManyTableNameTests.cs

@@ -30,8 +30,8 @@ public void ShouldHaveSameTableNameForBothSidesOfMapping()
 
             var mappings = model.BuildMappings();
 
-            var leftMapping = mappings.SelectMany(x => x.Classes).Where(x => x.Type == typeof(Left)).First();
-            var rightMapping = mappings.SelectMany(x => x.Classes).Where(x => x.Type == typeof(Right)).First();
+            var leftMapping = mappings.SelectMany(x => x.Classes).First(x => x.Type == typeof(Left));
+            var rightMapping = mappings.SelectMany(x => x.Classes).First(x => x.Type == typeof(Right));
 
             leftMapping.Collections.First().TableName.ShouldEqual("LeftsToRights");
             rightMapping.Collections.First().TableName.ShouldEqual("LeftsToRights");
@@ -57,8 +57,8 @@ public void ShouldHaveSameTableNameForBothSidesOfMappingWhenLeftSpecified()
 
             var mappings = model.BuildMappings();
 
-            var leftMapping = mappings.SelectMany(x => x.Classes).Where(x => x.Type == typeof(Left)).First();
-            var rightMapping = mappings.SelectMany(x => x.Classes).Where(x => x.Type == typeof(Right)).First();
+            var leftMapping = mappings.SelectMany(x => x.Classes).First(x => x.Type == typeof(Left));
+            var rightMapping = mappings.SelectMany(x => x.Classes).First(x => x.Type == typeof(Right));
 
             leftMapping.Collections.First().TableName.ShouldEqual("MyJoinTable");
             rightMapping.Collections.First().TableName.ShouldEqual("MyJoinTable");
@@ -84,8 +84,8 @@ public void ShouldHaveSameTableNameForBothSidesOfMappingWhenRightSpecified()
 
             var mappings = model.BuildMappings();
 
-            var leftMapping = mappings.SelectMany(x => x.Classes).Where(x => x.Type == typeof(Left)).First();
-            var rightMapping = mappings.SelectMany(x => x.Classes).Where(x => x.Type == typeof(Right)).First();
+            var leftMapping = mappings.SelectMany(x => x.Classes).First(x => x.Type == typeof(Left));
+            var rightMapping = mappings.SelectMany(x => x.Classes).First(x => x.Type == typeof(Right));
 
             leftMapping.Collections.First().TableName.ShouldEqual("MyJoinTable");
             rightMapping.Collections.First().TableName.ShouldEqual("MyJoinTable");
@@ -109,7 +109,7 @@ public void ShouldHaveSameTableNameForUniDirectionalMapping()
 
             var mappings = model.BuildMappings();
 
-            var leftMapping = mappings.SelectMany(x => x.Classes).Where(x => x.Type == typeof(Left)).First();
+            var leftMapping = mappings.SelectMany(x => x.Classes).First(x => x.Type == typeof(Left));
 
             leftMapping.Collections.First().TableName.ShouldEqual("RightToLeft");
         }
@@ -135,8 +135,8 @@ public void ShouldHaveSameTableNameForBothSidesOfMappingWhenHasMultipleBiDirecti
 
             var mappings = model.BuildMappings();
 
-            var leftMapping = mappings.SelectMany(x => x.Classes).Where(x => x.Type == typeof(Left)).First();
-            var rightMapping = mappings.SelectMany(x => x.Classes).Where(x => x.Type == typeof(Right)).First();
+            var leftMapping = mappings.SelectMany(x => x.Classes).First(x => x.Type == typeof(Left));
+            var rightMapping = mappings.SelectMany(x => x.Classes).First(x => x.Type == typeof(Right));
 
             leftMapping.Collections.First().TableName.ShouldEqual("LeftsToRights");
             rightMapping.Collections.First().TableName.ShouldEqual("LeftsToRights");
@@ -165,8 +165,8 @@ public void ShouldAllowConventionsToAlterBiDirectionalTableNames()
 
             var mappings = model.BuildMappings();
 
-            var leftMapping = mappings.SelectMany(x => x.Classes).Where(x => x.Type == typeof(Left)).First();
-            var rightMapping = mappings.SelectMany(x => x.Classes).Where(x => x.Type == typeof(Right)).First();
+            var leftMapping = mappings.SelectMany(x => x.Classes).First(x => x.Type == typeof(Left));
+            var rightMapping = mappings.SelectMany(x => x.Classes).First(x => x.Type == typeof(Right));
 
             leftMapping.Collections.First().TableName.ShouldEqual("Lefts_Rights");
             rightMapping.Collections.First().TableName.ShouldEqual("Lefts_Rights");
@@ -191,7 +191,7 @@ public void ShouldAllowConventionsToAlterUniDirectionalTableNames()
 
             var mappings = model.BuildMappings();
 
-            var leftMapping = mappings.SelectMany(x => x.Classes).Where(x => x.Type == typeof(Left)).First();
+            var leftMapping = mappings.SelectMany(x => x.Classes).First(x => x.Type == typeof(Left));
 
             leftMapping.Collections.First().TableName.ShouldEqual("RightUni");
         }