Update NuGet dotnet version to 6 and 8 and remove .netcoreapp2.0 #668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and remove .netcoreapp2.0
hazzik
reviewed
Mar 18, 2025
| @@ -25,7 +25,8 @@ public class BuildPaths | |||
| var artifactsBinDir = artifactsDir.Combine("bin"); | |||
| var artifactsBinFullFx = artifactsBinDir.Combine("net461"); | |||
| var artifactsBinNetStandard20 = artifactsBinDir.Combine("netstandard2.0"); | |||
| var artifactsBinNetCoreapp2 = artifactsBinDir.Combine("netcoreapp2.0"); | |||
| var artifactsBinNet60 = artifactsBinDir.Combine("netstandard6.0"); | |||
| var artifactsBinNet80 = artifactsBinDir.Combine("netstandard8.0"); | |||
There was a problem hiding this comment.
This and above should be "net8.0" and "net6.0" respectively
There was a problem hiding this comment.
Happy to make the change if there's interest in merging this PR. Only ask as it's 12 months old.
|
This makes sense to me. Except .Net 6 is now also expired so I guess there's no need to add that version at this point. Standard2 and .Net 8 should be appropriate for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the NuGet package to provide libraries for .NET 6.0 and 8.0. Also removed .NET Core 2.0 as it went EOL in 2018 (almost 6 years ago).
build.ps1runs locally and the generated nuget package contains the .NET 6/8 packagesI didn't add support for .NET 7.0 as it'll go EOL very soon (May this year). Let me know if you'd like to support it and I can add it in.
Adding later versions of .NET lets us use classes/functions such as
SpanorSearchValuesand provides nullability annotation for the standard library.