Skip to content

Upgrade Async Generator to a version compatible with VS 15.6.3 #1621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2018
Merged

Upgrade Async Generator to a version compatible with VS 15.6.3 #1621

merged 1 commit into from
Mar 21, 2018

Conversation

fredericDelaporte
Copy link
Member

We can no more generate async code after having upgraded to VS 15.6.3 otherwise.

Async files regenerated by the way. No new option were taken into account and adjusted in the yml.

@fredericDelaporte fredericDelaporte added this to the 5.1.1 milestone Mar 20, 2018
@hazzik
Copy link
Member

hazzik commented Mar 20, 2018

Let's probably wait maca88/AsyncGenerator#88 to be fixed.

@hazzik
Copy link
Member

hazzik commented Mar 20, 2018 •
edited
Loading

@maca88 can we possibly get 0.8.3 with the MSBuild bug fixed (upgraded MSBuild)?
@fredericDelaporte I'm too afraid to change the generation in a patch version. This is debatable.

@hazzik hazzik changed the title Upgrade Async Generator to a version compatible with VS 15.6.3. Upgrade Async Generator to a version compatible with VS 15.6.3 Mar 20, 2018
@fredericDelaporte
Copy link
Member Author

Understandable.

@fredericDelaporte
Copy link
Member Author

fredericDelaporte commented Mar 20, 2018 •
edited
Loading

can we possibly get 0.8.3

NHibernate is currently at 0.8.2.

Update: so maybe you mean get 0.8.2.1, because 0.8.3 already exists, without the bug fix.

@maca88
Copy link
Contributor

maca88 commented Mar 20, 2018 •
edited by fredericDelaporte
Loading

@hazzik I published the version 0.8.2.1 that contains the MSBuild upgrade. Do note that the mentioned bug is due to the MSBuild upgrade, so it is also failing for 0.8.2.1. If you actually meant 0.8.3 + MSBuild upgrade, I can create also a 0.8.3.1 package.

@hazzik
Copy link
Member

hazzik commented Mar 20, 2018

Yes, you've both got me right - I meant 0.8.2 + msbuild. (I forgot that 0.8.3 exists).

@fredericDelaporte
Copy link
Member Author

fredericDelaporte commented Mar 20, 2018 •
edited
Loading

Now that does just update to 0.8.2.1, and the regen does not change anything anymore.

@hazzik hazzik merged commit 274cf37 into nhibernate:master Mar 21, 2018
@fredericDelaporte fredericDelaporte deleted the UpgradeAsyncGenerator branch March 21, 2018 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hazzik hazzik hazzik approved these changes

Assignees
No one assigned
Labels
c: Async p: Major r: Fixed t: Task
Projects
None yet
Milestone
5.1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@fredericDelaporte @hazzik @maca88