Skip to content

Fixed CriteriaImpl.Clone for readonly query #1696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2018
Merged

Fixed CriteriaImpl.Clone for readonly query #1696

merged 1 commit into from
May 15, 2018

Conversation

bahusoid
Copy link
Member

@bahusoid bahusoid commented May 15, 2018 •
edited
Loading

While fixing #1681 I've noticed that readonly setting is also lost after Clone

@fredericDelaporte
Copy link
Member

You mean, this fix an old bug actually unrelated to #1681 but likely seen by the way? So

Noticed that readonly setting is also lost after Clone

Should be understood as:

I have noticed that the readonly setting is also lost after Clone. This PR fixes that loss.

@fredericDelaporte fredericDelaporte added this to the 5.2 milestone May 15, 2018
@bahusoid bahusoid changed the title Fixed CriteriaImpl.Clone for readonly Fixed CriteriaImpl.Clone for readonly query May 15, 2018
@bahusoid
Copy link
Member Author

Yep. Updated description to make it more clear

@hazzik hazzik merged commit 5c3033a into nhibernate:master May 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredericDelaporte fredericDelaporte fredericDelaporte approved these changes

Assignees
No one assigned
Labels
c: Core p: Minor r: Fixed t: Bug
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.
3 participants
@bahusoid @fredericDelaporte @hazzik