Skip to content

Fix DbType.Binary registration in DB2Dialect #1741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2018
Merged

Fix DbType.Binary registration in DB2Dialect #1741

merged 1 commit into from
Jun 10, 2018

Conversation

hazzik
Copy link
Member

@hazzik hazzik commented Jun 9, 2018

Was throwing:

System.ArgumentException : Dialect does not support DbType.Binary
Parameter name: typecode
   at NHibernate.Dialect.TypeNames.Get(DbType typecode)
   at NHibernate.Dialect.Dialect.GetTypeName(SqlType sqlType)
   at NHibernate.Mapping.Column.GetDialectTypeName(Dialect dialect, IMapping mapping)
   at NHibernate.Mapping.Column.GetSqlType(Dialect dialect, IMapping mapping)
   at NHibernate.Mapping.Table.SqlCreateString(Dialect dialect, IMapping p, String defaultCatalog, String defaultSchema)
   at NHibernate.Cfg.Configuration.GenerateSchemaCreationScript(Dialect dialect)
   at NHibernate.Tool.hbm2ddl.SchemaExport.Initialize()
   at NHibernate.Tool.hbm2ddl.SchemaExport.Execute(Action`1 scriptAction, Boolean execute, Boolean justDrop, TextWriter exportOutput)
   at NHibernate.Tool.hbm2ddl.SchemaExport.Execute(Action`1 scriptAction, Boolean execute, Boolean justDrop)
   at NHibernate.Tool.hbm2ddl.SchemaExport.Execute(Boolean useStdOut, Boolean execute, Boolean justDrop)
   at NHibernate.Tool.hbm2ddl.SchemaExport.Create(Boolean useStdOut, Boolean execute)

@hazzik hazzik added this to the 5.2 milestone Jun 9, 2018
@hazzik
Copy link
Member Author

hazzik commented Jun 9, 2018

@fredericDelaporte 5.1.3 or 5.2?

@hazzik hazzik changed the title Fix DbType.Binary registration in DB2 Fix DbType.Binary registration in DB2Dialect Jun 9, 2018
@hazzik hazzik removed this from the 5.2 milestone Jun 9, 2018
@fredericDelaporte
Copy link
Member

As you wish.

@hazzik hazzik changed the base branch from master to 5.1.x June 10, 2018 05:28
@hazzik hazzik added this to the 5.1.3 milestone Jun 10, 2018
@hazzik hazzik merged commit 059cabf into nhibernate:5.1.x Jun 10, 2018
@hazzik hazzik deleted the db2 branch June 10, 2018 05:34
hazzik added a commit to fredericDelaporte/nhibernate-core that referenced this pull request Jun 10, 2018
@hazzik
Update releasenotes.txt
144b088 
Add nhibernate#1741
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredericDelaporte fredericDelaporte fredericDelaporte approved these changes

Assignees
No one assigned
Labels
c: DataProviders / Dialects p: Lowest r: Fixed t: Bug
Projects
None yet
Milestone
5.1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@hazzik @fredericDelaporte