NH-3372: Enabled use of generated properties in combination with custom ... #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3965,7 +3965,23 @@ public void ProcessInsertGeneratedProperties(object id, object entity, object[] | |||
| { | |||
| throw new AssertionFailure("no insert-generated properties"); | |||
| } | |||
| ProcessGeneratedProperties(id, entity, state, session, sqlInsertGeneratedValuesSelectString, PropertyInsertGenerationInclusions); | |||
|
|
|||
| session.Batcher.ExecuteBatch(); //force immediate execution of the insert | |||
There was a problem hiding this comment.
why do we need that?
it seems that it is from inlined code
|
Confirmed, the session.Batcher.ExecuteBatch() calls were already present in the original code. |
|
@ggeurts please rebase on top of master branch |
ggeurts
force-pushed
the
custom-generate
branch
2 times, most recently
from
295ea7b to
0644587
Compare
Enables use of generated properties in combination with custom loader.
ggeurts
force-pushed
the
custom-generate
branch
from
0644587 to
ba21fbb
Compare
|
Rebase completed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...loader.
When a column is specified as generated, the AsbtractEntityPersister always generates SELECT statements to read the generated data. This does not work well when the entities are loaded with a named query by specifying a element in the entity mapping.
The solution is to fall back to reloading the entity using the named query if generated properties must be read.