NH-3499 - Allow custom QueryModelVisitorBase to be provided through the session factory #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wonderful feature! I wonder when these merges will happen I am waiting for mine more than 2 months |
|
No support for loquacious configuration? :-) |
|
@pvginkel can you please rebase this on top of master and add ability to configure this option through maping by code? |
…he session factory Implements a new parameter on the session factory to provide a IQueryModelRewriterFactory which is used in QueryModelVisitor to allow the query model to be rewritten.
|
The code has been rebased onto the master and support for mapping by code has been implemented. It seems that the unit testing framework changed, so that has been updated to. One thing though: I have no experience with mapping by code. Can you (somebody) check whether I did the right thing? It looks OK to me but I may have missed something. |
|
Looks good. Thanks a lot @pvginkel! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a new parameter on the session factory to provide a IQueryModelRewriterFactory which is used in QueryModelVisitor to allow the query model to be rewritten.