Apply filters for entity joins in hql #2550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bahusoid
changed the title
hazzik
reviewed
Sep 17, 2020
src/NHibernate/Hql/Ast/ANTLR/Tree/EntityJoinJoinSequenceImpl.cs
Outdated
Show resolved
Hide resolved
|
Is it a backport of some changes from |
hazzik
reviewed
Sep 17, 2020
src/NHibernate/Hql/Ast/ANTLR/Tree/EntityJoinJoinSequenceImpl.cs
Outdated
Show resolved
Hide resolved
hazzik
reviewed
Sep 17, 2020
hazzik
approved these changes
Sep 17, 2020
hazzik
approved these changes
Sep 18, 2020
|
When merging to master in case of conflicts (due to #2361) - just take changes from 5.3.x branch. |
Merged
bahusoid
added a commit
to bahusoid/nhibernate-core
that referenced
this pull request
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2549
Just make
JoinSequenceapply standard logic that takes care of everything