Fix caching linq query with ThenFetchMany #2558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you mean this was working with 5.2.x? |
hazzik
reviewed
Sep 21, 2020
src/NHibernate.Test/NHSpecificTest/CachingComplexQuery/FixtureByCode.cs
Outdated
Show resolved
Hide resolved
src/NHibernate.Test/NHSpecificTest/CachingComplexQuery/FixtureByCode.cs
Outdated
Show resolved
Hide resolved
src/NHibernate.Test/NHSpecificTest/CachingComplexQuery/FixtureByCode.cs
Outdated
Show resolved
Hide resolved
Yes, it was working with 5.2.7 |
maca88
force-pushed
the
CachingQueryWithThenFetchMany
branch
from
38a0e2a to
9e1f930
Compare
|
Rebased to |
maca88
force-pushed
the
CachingQueryWithThenFetchMany
branch
from
08913f1 to
e6662d6
Compare
bahusoid
reviewed
Sep 22, 2020
fredericDelaporte
changed the title
hazzik
approved these changes
Sep 22, 2020
bahusoid
pushed a commit
to bahusoid/nhibernate-core
that referenced
this pull request
Aug 10, 2021
Fixes nhibernate#2559 Co-authored-by: maca88 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit contains an unit test for #2559 that performs caching linq query with using ThenFetchMany statement and tries to retrieve cached query result set. Starting from nhibernate 5.3 retrieving such cached query result set is not working so unit test is failing. Actually an unit test shows the bug in nhibernate 5.3.