Skip to content

Fix missing ConfigureAwait(false) in FutureEnumerable #2678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 15, 2021
Merged

Fix missing ConfigureAwait(false) in FutureEnumerable #2678

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df82c69
Fix missing ConfigureAwait(false) in FutureEnumerable
bahusoid Feb 15, 2021
fffa211
Make it auto generated
bahusoid Feb 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/NHibernate/Async/Multi/QueryBatchExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,16 @@ partial class FutureList<TResult> : IFutureList<TResult>
}
}

partial class FutureEnumerable<TResult> : IFutureEnumerable<TResult>
{

public async Task<IEnumerable<TResult>> GetEnumerableAsync(CancellationToken cancellationToken = default(CancellationToken))
{
cancellationToken.ThrowIfCancellationRequested();
return await (_result.GetValueAsync(cancellationToken)).ConfigureAwait(false);
}
}

#endregion Helper classes
}
}
7 changes: 1 addition & 6 deletions src/NHibernate/Multi/QueryBatchExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,7 +567,7 @@ public IList<TResult> Value
}
}

class FutureEnumerable<TResult> : IFutureEnumerable<TResult>
partial class FutureEnumerable<TResult> : IFutureEnumerable<TResult>
{
private readonly IFutureList<TResult> _result;

Expand All @@ -576,11 +576,6 @@ public FutureEnumerable(IQueryBatch batch, IQueryBatchItem<TResult> query)
_result = new FutureList<TResult>(batch, query);
}

public async Task<IEnumerable<TResult>> GetEnumerableAsync(CancellationToken cancellationToken = default(CancellationToken))
{
return await _result.GetValueAsync(cancellationToken);
}

public IEnumerable<TResult> GetEnumerable()
{
return _result.Value;
Expand Down