Skip to content

Fix intermittent Firebird test errors #2813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix intermittent Firebird test errors #2813

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/NHibernate.Test/TestCase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,9 @@ protected virtual void DropSchema()

public static void DropSchema(bool useStdOut, SchemaExport export, ISessionFactoryImplementor sfi, Func<DbConnection> getConnection = null)
{
using(var optionalConnection = getConnection?.Invoke())
export.Drop(useStdOut, true, optionalConnection);

if (sfi?.ConnectionProvider.Driver is FirebirdClientDriver fbDriver)
{
// Firebird will pool each connection created during the test and will marked as used any table
Expand All @@ -313,9 +316,6 @@ public static void DropSchema(bool useStdOut, SchemaExport export, ISessionFacto
// Moved from NH1908 test case, contributed by Amro El-Fakharany.
fbDriver.ClearPool(null);
}

using(var optionalConnection = getConnection?.Invoke())
export.Drop(useStdOut, true, optionalConnection);
}

/// <summary>
Expand Down