NH-2611 - Allow injectable/inheritance of Linq query provider

[rjperes]

https://nhibernate.jira.com/browse/NH-2611

[hazzik]

@rjperes it seems that you've forgot to set default linq provider.

[rjperes]

Hmm, no, that's what this does:

string className = PropertiesHelper.GetString(
Environment.QueryLinqProvider, properties, typeof(DefaultQueryProvider).FullName);

Will have a look.

[rjperes]

The problem does not happen in my machine, all tests are green. Any thoughts?

[hazzik]

@rjperes I saw your original message ;)

[rjperes]

@hazzik :-)
And do you have any ideas as to why the tests are failing?

[oskarb]

The error message on the build server is
[18:34:52] : [exec] 1) SetUp Error : NHibernate.Test.Linq.LinqReadonlyTestsContext
[18:34:52] : [exec] SetUp : System.Data.SqlClient.SqlException : There is insufficient system memory in resource pool 'internal' to run this query.

Might have been temporary. I've started the same build again.

[rjperes]

Can you update the fix version in Jira?

[hazzik]

Typo in the file name

[rjperes]

Yes, but not mine! :-) I used a file that was already there

[hazzik]

Ok

[rjperes]

OK, added a factory method
I was wondering: any benefit in caching the query provider per session? Maybe more trouble than it's worth (instances piling up in the cache, etc)

[hazzik]

@rjperes, can you please do following

$git fetch --all --prune
$git checkout NH-2890
$git reset 3765630 --hard

[hazzik]

Internal, please

[rjperes]

Well, if we are to have a plugable mechanism, why not allow developers from inheriting from existing classes and change its behavior? For that, we need virtual methods, right? I mean, most people won't create a brand new query provider, but instead inherit from the existing one.
As for the internal visibility, ok, will update the code

[hazzik]

Ok, right..

[hazzik]

@rjperes can you please do following?

git fetch --all --prune

[rjperes]

Just did

[hazzik]

@rjperes could you please document this new configuration setting?

[rjperes]

Ok.