Skip to content

Force left join for comparisons with nullable entities #3270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 26, 2023
Merged

Force left join for comparisons with nullable entities #3270

merged 3 commits into from
Mar 26, 2023

Conversation

bahusoid
Copy link
Member

@bahusoid bahusoid commented Mar 25, 2023 •
edited
Loading

Fixes #3269
Yet another regression from #2081

I hope I finally found a safe way to add left implied join in #3187 so this change should be safe too.

Includes a partial revert of no longer used change from #2889

@fredericDelaporte fredericDelaporte added this to the 5.3.16 milestone Mar 25, 2023
@bahusoid bahusoid merged commit 7deea30 into nhibernate:5.3.x Mar 26, 2023
@bahusoid bahusoid mentioned this pull request Mar 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredericDelaporte fredericDelaporte fredericDelaporte approved these changes

Assignees
No one assigned
Labels
r: Fixed t: Fix
Projects
None yet
Milestone
5.3.16
Development

Successfully merging this pull request may close these issues.
2 participants
@bahusoid @fredericDelaporte