Skip to content

Clean up Linq Joiner class removing no longer needed AddJoinMethod property #3391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Clean up Linq Joiner class removing no longer needed AddJoinMethod property #3391

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3125b1
Clean up Linq Joiner class removing no longer needed AddJoinMethod pr…
bahusoid Aug 1, 2023
2466e6b
Merge branch 'master' into cleanUpJoinBuilder
bahusoid Aug 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/NHibernate/Linq/Visitors/JoinBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,7 @@ internal Joiner(QueryModel queryModel)
{
_nameGenerator = new NameGenerator(queryModel);
_queryModel = queryModel;
AddJoinMethod = AddJoin;
}

internal System.Action<QueryModel, NhJoinClause> AddJoinMethod { get; }

public IEnumerable<NhJoinClause> Joins
{
Expand All @@ -42,7 +39,7 @@ public Expression AddJoin(Expression expression, string key)
if (!_joins.TryGetValue(key, out join))
{
join = new NhJoinClause(_nameGenerator.GetNewName(), expression.Type, expression);
AddJoinMethod(_queryModel, join);
AddJoin(_queryModel, join);
_joins.Add(key, join);
}

Expand Down