NH-3198 - Have Mapping By Code Support Dynamic Component Inside Join #366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omponent Inside Join
There was a problem hiding this comment.
Test is failing because of line endings. Please change it to assert specific items you want to check. Please see other mapping-by-code tests.
There was a problem hiding this comment.
Replaced with 6 tests, checking the hbm mapping-by-code built model
…roperties to root or joined table
|
Need to cleanup indents: we are using tabs instead of spaces. |
hazzik
changed the title
|
Hi @Radim-Kohler, I've made minor modifications to this PR and pushed to master. Thanks for the contribution. The modifications are following:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal of a fix:
NH-3198 - Have Mapping By Code Support Dynamic Component Inside Join
There are three adjustments in the code, One new test (Not the best, comparing expected and resulting XML...)