Skip to content

Fixed a misspelled word #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

michaelakin
Copy link
Contributor

I found a misspelled word (ContraintOrderedTableKeyColumnClosure) when I was inspecting an object and I wanted to correct it.

Thanks,
Michael

@hazzik hazzik added this to the 5.0.0 milestone Dec 10, 2014
@hazzik
Copy link
Member

hazzik commented Dec 10, 2014

This will go to 5.0.0 as it is a breaking change. Also please create a JIRA issue.

@michaelakin
Copy link
Contributor Author

Thanks. I created Jira ticket NH-3744
https://nhibernate.jira.com/browse/NH-3744

Just wondering, why is it a breaking change?

@hazzik
Copy link
Member

hazzik commented Dec 10, 2014

Because you are changing interface and abstract member

@michaelakin
Copy link
Contributor Author

Ok, Thanks @hazzik

@hazzik hazzik changed the base branch from master to 5.0.x October 26, 2016 22:33
@oskarb oskarb closed this Nov 28, 2016
@hazzik hazzik changed the base branch from 5.0.x to master November 29, 2016 00:03
@hazzik hazzik reopened this Nov 29, 2016
@oskarb
Copy link
Member

oskarb commented Dec 4, 2016

Thanks, I've merged a rebased commit to master as 39243fc.

@oskarb oskarb closed this Dec 4, 2016
@hazzik hazzik added the r: Fixed label Aug 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants