The proposed fix for NH-3757 "Dynamic entity mapped with entity-name cannot have a component of a fixed class"

[ogvolkov]

A fix for "Dynamic entity mapped with entity-name cannot have a component of a fixed class"
https://nhibernate.jira.com/browse/NH-3757

[ogvolkov]

Hello, can we proceed with this patch, as it's been in limbo for two years? Granted it's not critical at all, but the changes are pretty minor, so what can I do to make sure it's merged?

[fredericDelaporte]

In case someone tries to check what is going on with this feature on Hibernate side, here is my findings.

On Hibernate side, the feature of mixing dynamic with fixed seems to have been dropped with HHH-6330, without much explanations in their tracking tool. A redesign of the metamodel is evoked in their release notes, but that was still WIP and not detailed. At least, its commit deletes the equivalent file to the one you have modified in NHibernate.
This file was still holding the condition you want to remove. And in their GitHub repository, this file first version was already having this condition.

So I guess the rational behind this condition being there in the first place is lost. (Unless someone knows where to look for previous to GitHub history of that file in Hibernate.)

[hazzik]

It has been moved here:

hibernate/hibernate-orm@4a4f636#diff-ec0cf8552c814a18b82690c9d5cb4136R76

[hazzik]

This logic follows hibernate logic from what I can see.

[hazzik]

@ogvolkov could you please squash and rebase on top of master, or enable the "Allow changes by maintainers" feature?

[hazzik]

Ok, merged. No action is required. Thanks.