Skip to content

NH-3403: Wrong parameter size in query with MsSql2000Dialect,MsSql2005Dialect and MsSql2008Dialect #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

NH-3403: Wrong parameter size in query with MsSql2000Dialect,MsSql2005Dialect and MsSql2008Dialect #480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
188 changes: 188 additions & 0 deletions src/NHibernate.Test/Async/NHSpecificTest/NH3403/Fixture.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,188 @@
//------------------------------------------------------------------------------
// <auto-generated>
// This code was generated by AsyncGenerator.
//
// Changes to this file may cause incorrect behavior and will be lost if
// the code is regenerated.
// </auto-generated>
//------------------------------------------------------------------------------


using System.Data;
using System.Data.SqlClient;
using System.Linq;
using NHibernate.Cfg;
using NHibernate.Criterion;
using NHibernate.Dialect;
using NHibernate.Driver;
using NHibernate.Engine;
using NHibernate.Exceptions;
using NHibernate.Linq;
using NUnit.Framework;

namespace NHibernate.Test.NHSpecificTest.NH3403
{
using System.Threading.Tasks;
using System.Threading;
[TestFixture]
public class FixtureAsync : BugTestCase
{
protected override bool AppliesTo(Dialect.Dialect dialect)
{
return dialect is MsSql2000Dialect;
}

protected override bool AppliesTo(ISessionFactoryImplementor factory)
{
return factory.ConnectionProvider.Driver is SqlClientDriver;
}

protected override void Configure(Configuration configuration)
{
cfg.SetProperty(Environment.ConnectionDriver, typeof(TestSqlClientDriver).AssemblyQualifiedName);
}

protected override void OnTearDown()
{
using (ISession session = OpenSession())
using (ITransaction transaction = session.BeginTransaction())
{
session.Delete("from System.Object");

session.Flush();
transaction.Commit();
}
}

protected override void OnSetUp()
{
base.OnSetUp();
using (ISession session = OpenSession())
using (ITransaction transaction = session.BeginTransaction())
{
var e1 = new Entity { Name = "Bob" };
session.Save(e1);
transaction.Commit();
}
}

[Test]
public async Task InsertShouldUseMappedSizeAsync()
{
Driver.ClearCommands();

using (ISession session = OpenSession())
using (ITransaction transaction = session.BeginTransaction())
{
var e1 = new Entity { Name = "Al", AnsiName = "Al" };
await (session.SaveAsync(e1));
await (transaction.CommitAsync());
Assert.AreEqual(SqlDbType.NVarChar, Driver.LastCommandParameters.First().SqlDbType);
Assert.AreEqual(3, Driver.LastCommandParameters.First().Size);
Assert.AreEqual(SqlDbType.VarChar, Driver.LastCommandParameters.Last().SqlDbType);
Assert.AreEqual(3, Driver.LastCommandParameters.Last().Size);
}
}

[Test]
public void InsertWithTooLongValuesShouldThrowAsync()
{
Driver.ClearCommands();

using (ISession session = OpenSession())
using (ITransaction transaction = session.BeginTransaction())
{
var e1 = new Entity { Name = "Alal", AnsiName = "Alal" };

var ex = Assert.ThrowsAsync<GenericADOException>(
async () =>
{
await (session.SaveAsync(e1));
await (transaction.CommitAsync());
});

var sqlEx = ex.InnerException as SqlException;
Assert.IsNotNull(sqlEx);
Assert.That(sqlEx.Number, Is.EqualTo(8152));
}
}

[TestCase("Name", SqlDbType.NVarChar)]
[TestCase("AnsiName", SqlDbType.VarChar)]
public async Task LinqEqualsShouldUseMappedSizeAsync(string property, SqlDbType expectedDbType, CancellationToken cancellationToken = default(CancellationToken))
{
Driver.ClearCommands();

using (ISession session = OpenSession())
using (ITransaction transaction = session.BeginTransaction())
{
if (property == "Name")
{
await (session.Query<Entity>().Where(x => x.Name == "Bob").ToListAsync(cancellationToken));
}
else
{
await (session.Query<Entity>().Where(x => x.AnsiName == "Bob").ToListAsync(cancellationToken));
}
Assert.AreEqual(3, Driver.LastCommandParameters.First().Size);
Assert.AreEqual(expectedDbType, Driver.LastCommandParameters.First().SqlDbType);
}
}

[TestCase("Name", SqlDbType.NVarChar)]
[TestCase("AnsiName", SqlDbType.VarChar)]
public async Task HqlLikeShouldUseLargerSizeAsync(string property, SqlDbType expectedDbType, CancellationToken cancellationToken = default(CancellationToken))
{
Driver.ClearCommands();

using (ISession session = OpenSession())
using (ITransaction transaction = session.BeginTransaction())
{
await (session.CreateQuery("from Entity where " + property + " like :name").SetParameter("name", "%Bob%").ListAsync<Entity>(cancellationToken));

Assert.GreaterOrEqual(Driver.LastCommandParameters.First().Size, 5);
Assert.AreEqual(expectedDbType, Driver.LastCommandParameters.First().SqlDbType);
}
}

[TestCase("Name", SqlDbType.NVarChar)]
[TestCase("AnsiName", SqlDbType.VarChar)]
public async Task CriteriaEqualsShouldUseMappedSizeAsync(string property, SqlDbType expectedDbType, CancellationToken cancellationToken = default(CancellationToken))
{
Driver.ClearCommands();

using (ISession session = OpenSession())
using (ITransaction transaction = session.BeginTransaction())
{
Driver.ClearCommands();

await (session.CreateCriteria<Entity>().Add(Restrictions.Eq(property, "Bob"))
.ListAsync<Entity>(cancellationToken));

Assert.GreaterOrEqual(Driver.LastCommandParameters.First().Size, 3);
Assert.AreEqual(expectedDbType, Driver.LastCommandParameters.First().SqlDbType);
}
}

[TestCase("Name", SqlDbType.NVarChar)]
[TestCase("AnsiName", SqlDbType.VarChar)]
public async Task CriteriaLikeShouldUseLargerSizeAsync(string property, SqlDbType expectedDbType, CancellationToken cancellationToken = default(CancellationToken))
{
Driver.ClearCommands();

using (ISession session = OpenSession())
using (ITransaction transaction = session.BeginTransaction())
{
await (session.CreateCriteria<Entity>().Add(Restrictions.Like(property, "%Bob%"))
.ListAsync<Entity>(cancellationToken));

Assert.GreaterOrEqual(Driver.LastCommandParameters.First().Size, 5);
Assert.AreEqual(expectedDbType, Driver.LastCommandParameters.First().SqlDbType);
}
}
private TestSqlClientDriver Driver
{
get { return Sfi.ConnectionProvider.Driver as TestSqlClientDriver; }
}
}
}
9 changes: 9 additions & 0 deletions src/NHibernate.Test/NHSpecificTest/NH3403/Entity.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
namespace NHibernate.Test.NHSpecificTest.NH3403
{
class Entity
{
public virtual int Id { get; set; }
public virtual string Name { get; set; }
public virtual string AnsiName { get; set; }
}
}
176 changes: 176 additions & 0 deletions src/NHibernate.Test/NHSpecificTest/NH3403/Fixture.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,176 @@
using System.Data;
using System.Data.SqlClient;
using System.Linq;
using NHibernate.Cfg;
using NHibernate.Criterion;
using NHibernate.Dialect;
using NHibernate.Driver;
using NHibernate.Engine;
using NHibernate.Exceptions;
using NHibernate.Linq;
using NUnit.Framework;

namespace NHibernate.Test.NHSpecificTest.NH3403
{
[TestFixture]
public class Fixture : BugTestCase
{
protected override bool AppliesTo(Dialect.Dialect dialect)
{
return dialect is MsSql2000Dialect;
}

protected override bool AppliesTo(ISessionFactoryImplementor factory)
{
return factory.ConnectionProvider.Driver is SqlClientDriver;
}

protected override void Configure(Configuration configuration)
{
cfg.SetProperty(Environment.ConnectionDriver, typeof(TestSqlClientDriver).AssemblyQualifiedName);
}

protected override void OnTearDown()
{
using (ISession session = OpenSession())
using (ITransaction transaction = session.BeginTransaction())
{
session.Delete("from System.Object");

session.Flush();
transaction.Commit();
}
}

protected override void OnSetUp()
{
base.OnSetUp();
using (ISession session = OpenSession())
using (ITransaction transaction = session.BeginTransaction())
{
var e1 = new Entity { Name = "Bob" };
session.Save(e1);
transaction.Commit();
}
}

[Test]
public void InsertShouldUseMappedSize()
{
Driver.ClearCommands();

using (ISession session = OpenSession())
using (ITransaction transaction = session.BeginTransaction())
{
var e1 = new Entity { Name = "Al", AnsiName = "Al" };
session.Save(e1);
transaction.Commit();
Assert.AreEqual(SqlDbType.NVarChar, Driver.LastCommandParameters.First().SqlDbType);
Assert.AreEqual(3, Driver.LastCommandParameters.First().Size);
Assert.AreEqual(SqlDbType.VarChar, Driver.LastCommandParameters.Last().SqlDbType);
Assert.AreEqual(3, Driver.LastCommandParameters.Last().Size);
}
}

[Test]
public void InsertWithTooLongValuesShouldThrow()
{
Driver.ClearCommands();

using (ISession session = OpenSession())
using (ITransaction transaction = session.BeginTransaction())
{
var e1 = new Entity { Name = "Alal", AnsiName = "Alal" };

var ex = Assert.Throws<GenericADOException>(
() =>
{
session.Save(e1);
transaction.Commit();
});

var sqlEx = ex.InnerException as SqlException;
Assert.IsNotNull(sqlEx);
Assert.That(sqlEx.Number, Is.EqualTo(8152));
}
}

[TestCase("Name", SqlDbType.NVarChar)]
[TestCase("AnsiName", SqlDbType.VarChar)]
public void LinqEqualsShouldUseMappedSize(string property, SqlDbType expectedDbType)
{
Driver.ClearCommands();

using (ISession session = OpenSession())
using (ITransaction transaction = session.BeginTransaction())
{
if (property == "Name")
{
session.Query<Entity>().Where(x => x.Name == "Bob").ToList();
}
else
{
session.Query<Entity>().Where(x => x.AnsiName == "Bob").ToList();
}
Assert.AreEqual(3, Driver.LastCommandParameters.First().Size);
Assert.AreEqual(expectedDbType, Driver.LastCommandParameters.First().SqlDbType);
}
}

[TestCase("Name", SqlDbType.NVarChar)]
[TestCase("AnsiName", SqlDbType.VarChar)]
public void HqlLikeShouldUseLargerSize(string property, SqlDbType expectedDbType)
{
Driver.ClearCommands();

using (ISession session = OpenSession())
using (ITransaction transaction = session.BeginTransaction())
{
session.CreateQuery("from Entity where " + property + " like :name").SetParameter("name", "%Bob%").List<Entity>();

Assert.GreaterOrEqual(Driver.LastCommandParameters.First().Size, 5);
Assert.AreEqual(expectedDbType, Driver.LastCommandParameters.First().SqlDbType);
}
}

[TestCase("Name", SqlDbType.NVarChar)]
[TestCase("AnsiName", SqlDbType.VarChar)]
public void CriteriaEqualsShouldUseMappedSize(string property, SqlDbType expectedDbType)
{
Driver.ClearCommands();

using (ISession session = OpenSession())
using (ITransaction transaction = session.BeginTransaction())
{
Driver.ClearCommands();

session.CreateCriteria<Entity>().Add(Restrictions.Eq(property, "Bob"))
.List<Entity>();

Assert.GreaterOrEqual(Driver.LastCommandParameters.First().Size, 3);
Assert.AreEqual(expectedDbType, Driver.LastCommandParameters.First().SqlDbType);
}
}

[TestCase("Name", SqlDbType.NVarChar)]
[TestCase("AnsiName", SqlDbType.VarChar)]
public void CriteriaLikeShouldUseLargerSize(string property, SqlDbType expectedDbType)
{
Driver.ClearCommands();

using (ISession session = OpenSession())
using (ITransaction transaction = session.BeginTransaction())
{
session.CreateCriteria<Entity>().Add(Restrictions.Like(property, "%Bob%"))
.List<Entity>();

Assert.GreaterOrEqual(Driver.LastCommandParameters.First().Size, 5);
Assert.AreEqual(expectedDbType, Driver.LastCommandParameters.First().SqlDbType);
}
}
private TestSqlClientDriver Driver
{
get { return Sfi.ConnectionProvider.Driver as TestSqlClientDriver; }
}
}
}
10 changes: 10 additions & 0 deletions src/NHibernate.Test/NHSpecificTest/NH3403/Mappings.hbm.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<?xml version="1.0" encoding="utf-8" ?>
<hibernate-mapping xmlns="urn:nhibernate-mapping-2.2" assembly="NHibernate.Test" namespace="NHibernate.Test.NHSpecificTest.NH3403">

<class name="Entity">
<id name="Id" generator="native" />
<property name="Name" length="3"/>
<property name="AnsiName" length="3" type="AnsiString"/>
</class>

</hibernate-mapping>
Loading