Skip to content

[WIP] Use nuget package instead of local libraries #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

hazzik
Copy link
Member

@hazzik hazzik commented Aug 4, 2016

No description provided.

@hazzik hazzik changed the title Use nuget package instead of local libraries [WIP] Use nuget package instead of local libraries Aug 4, 2016
@hazzik hazzik force-pushed the nuget branch 2 times, most recently from b4411c8 to db366a0 Compare August 7, 2016 01:07
@ngbrown
Copy link
Contributor

ngbrown commented Oct 22, 2016

I think using NuGet is a great idea. I noticed that src/NHibernate/packages.config doesn't have all of the database providers that NHibernate supports. Since the current NHibernate loads drivers that exist ambient in the directory by reflection, it doesn't need to include them. However, I think this is a good point to introduce splitting the different database providers into separate packages so each provider NuGet package can then depend on specific version ranges of the database provider NuGet packages.

For example, there would be a NHibernate.SQLServer, NHibernate.SQLite, NHibernate.Oracle, and so on. Each of these would then depend on the main NHibernate package and a provider package such as Oracle.ManagedDataAccess.

This way, reflection would no longer be needed and developers could be sure that the provider packages were pulled down along with NHibernate.

@hazzik
Copy link
Member Author

hazzik commented Feb 13, 2017

Superseded by #549

@hazzik hazzik closed this Feb 13, 2017
@hazzik hazzik deleted the nuget branch February 13, 2017 00:50
@hazzik hazzik restored the nuget branch February 13, 2017 00:51
@hazzik hazzik reopened this Feb 13, 2017
@hazzik hazzik closed this Feb 13, 2017
@hazzik hazzik deleted the nuget branch February 13, 2017 00:57
@hazzik hazzik modified the milestone: 5.0.0 Mar 1, 2017
@hazzik hazzik removed this from the 5.0 milestone Aug 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants