Skip to content

Adding some prerequisites for having tests passing. #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2017

Conversation

fredericDelaporte
Copy link
Member

I had some difficulties getting all tests supposed to pass actually passing, due to some mismatch in my SQL server configuration with what some tests assume.

So to help other wannabe contributors having those tests passing, I would like to add a note on those sql configuration assumption.

  • Case insensitive accent sensitive string matching. (My default test SQL Server collation is Latin1_General_100_CI_AI_SC...)
  • en-US SQL user locales. Some tests causes dates to be converted from string to date on db side, and fails with locales such as fr-FR. Other tests expect the db to raise some error message, and check it matches some English words, which fails if the error message was emitted in another language. (My SQL user was using French.)
  • With SQL Server, supplementary characters collations (_SC suffix) cause some tests on legacy types such as text and ntext to fail.

I had difficulties having the DTC tests passing too. But that was a trouble of DTC sort of "not fully enabled". (I had to follow http://stackoverflow.com/a/30959127/1178314.) It will not fit well in those contributors guides I think. (And I keep having some DTC failures, but it looks related to some glitches in current NHibernate DTC implementation, as said there.)

I have not written a Jira for those changes.
Should I? Or should I add a Jira only for changes impacting the deliverable?

@hazzik hazzik merged commit 1c05dcf into nhibernate:master Mar 1, 2017
@hazzik
Copy link
Member

hazzik commented Mar 1, 2017

Thanks. No JIRA required.

@hazzik hazzik modified the milestone: 5.0.0 Mar 1, 2017
@fredericDelaporte fredericDelaporte deleted the HowToTestMoreInfo branch March 1, 2017 08:39
@hazzik hazzik added the r: Fixed label Aug 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants