NH-2821 - another approach to finding log4net #73
Conversation
|
Can we test this behaviour somehow? |
|
印象笔记无法提交笔记，原因如下： 本月帐户上传流量已经达到上限。 原消息详情： 为了防止邮件过多，接下来的360分钟内，你将不会收到报错回复。 升级到印象笔记高级帐户，可以发送的邮件数量将从50封提升到200封。
|
…ra.com/browse/NH-2821 Instead of checking for file on disk (which might fail, for example when using ShadowCopy, like when running inside NUnit), check if log4net assembly is loaded in current AppDomain.
|
I used this patch in my project, to avoid need for special call to NHibernate to pick up log4net when running under Nunit test runner. I believe that creating test for that is possible, but would require creating app domain, it is far easier in this case to do manual test, code is simple and will not be changed often. |
|
@whut can you please rebase this on top of master? |
|
Merged 8692a59 |
https://nhibernate.jira.com/browse/NH-2821
Here is an updated pull request, like in #15. This time I just check if log4net is already loaded in current AppDomain, so now it does not matter if someone uses log4net or nhibernate from GAC or not!