[fix] Add prosemirror-transform to @toast-ui/editor dependencies#3202
Open
weaverryan wants to merge 1 commit intonhn:masterfrom
Open
[fix] Add prosemirror-transform to @toast-ui/editor dependencies#3202weaverryan wants to merge 1 commit intonhn:masterfrom
weaverryan wants to merge 1 commit intonhn:masterfrom
Conversation
This package is imported in several places, so it should be a dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)Description
Hi!
Sorry if this PR is misguided. I noticed that the
prosemirror-commandspackage is imported in several places - e.g. https://github.com/nhn/tui.editor/blob/master/apps/editor/src/wysiwyg/command/list.ts#L4 - but it was not listed underdependencies. We have a script that parsesdependenciesinpackage.jsonto do some dependency version checking for the Symfony PHP framework, which is how we stumped over this.I used the latest version - but that could almost certainly be changed to a lower version, if desired.
Thanks!