fix: error when rendering widgets inside table (fix #3198)#3261
Open
jgskillable wants to merge 6 commits intonhn:masterfrom
Open
fix: error when rendering widgets inside table (fix #3198)#3261jgskillable wants to merge 6 commits intonhn:masterfrom
jgskillable wants to merge 6 commits intonhn:masterfrom
Conversation
- Updated the Prettier configuration to automatically handle end-of-line settings. This ensures consistent line endings across different operating systems.
- Added the isCustomInline function to the HTML to WWConverter. This function helps in identifying custom inline elements, improving the conversion process.
- Updated the tableCell function in the toWwConverter to support checking if the node is a custom inline node. This fix addresses the issue of widgets inside table cells not being handled correctly.
- Updated the editor demo to support showcasing a widget inside a table cell. This addresses the issue where widgets were not supported correctly inside table cells.
- Bumped the package version to 3.2.3. This update includes fixing an issue where widgets weren't supported inside of table cells.
- Reverted changes to some version numbers from previous changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: Widgets inside of table cells causing data loss
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)Description
This PR addresses an issue where rendering widgets inside a table causes an error, resulting in the table cell being removed from both the visual and markdown views when switching modes. This leads to data loss. The fix is based on a previous bug report and potential solution found here.
Business Case
Fixing this issue is crucial for users who rely on the accurate rendering of widgets within tables. The current bug leads to data loss, which can significantly impact user productivity and trust in the application. By resolving this issue, we ensure a more reliable and seamless user experience, which is essential for maintaining user satisfaction and retention.
Steps to Reproduce
Open the TOAST UI Editor Demo:
Switch to Markdown Mode:
Add a Table with a Widget:
Switch to Visual Mode:
Observe the Table:
@Widget) is still present.Switch Back to Markdown Mode:
Check the Markdown Content:
editor.getMarkdown()and observe the output.Expected Result
@Widget) should be present in both Visual and Markdown modes.editor.getMarkdown()output should include the cell with the widget.Actual Result
editor.getMarkdown()output does not include the cell with the widget, resulting in data loss.fix: resolve a bug completely (#3198)
Thank you for your contribution to TOAST UI product. 🎉 😘 ✨