Use search input component in header#1696
Open
colinrotherham wants to merge 2 commits intocomponent-search-inputfrom
Open
Use search input component in header#1696colinrotherham wants to merge 2 commits intocomponent-search-inputfrom
colinrotherham wants to merge 2 commits intocomponent-search-inputfrom
Conversation
Contributor
|
Out of interest, how is this breaking? At a guess, markup is changed due to introduction of the wrapper? |
Contributor
Author
I've chosen to make it breaking so we could remove the (now) duplicated styles It'd be possible to support both if necessary |
colinrotherham
force-pushed
the
component-search-input
branch
2 times, most recently
from
baf6e69 to
e9d0f06
Compare
colinrotherham
force-pushed
the
component-search-input-header
branch
from
38adbf2 to
af2868d
Compare
colinrotherham
force-pushed
the
component-search-input
branch
from
e9d0f06 to
2be6bac
Compare
colinrotherham
force-pushed
the
component-search-input-header
branch
from
af2868d to
765538d
Compare
colinrotherham
force-pushed
the
component-search-input
branch
from
2be6bac to
80ccbff
Compare
colinrotherham
force-pushed
the
component-search-input-header
branch
from
765538d to
d4f02e5
Compare
colinrotherham
force-pushed
the
component-search-input
branch
from
80ccbff to
67fdee4
Compare
colinrotherham
force-pushed
the
component-search-input-header
branch
from
d4f02e5 to
bab15bd
Compare
colinrotherham
force-pushed
the
component-search-input
branch
from
67fdee4 to
93e0e1b
Compare
colinrotherham
force-pushed
the
component-search-input-header
branch
from
bab15bd to
80996d6
Compare
colinrotherham
force-pushed
the
component-search-input
branch
from
93e0e1b to
93755c9
Compare
colinrotherham
force-pushed
the
component-search-input-header
branch
from
80996d6 to
a624569
Compare
colinrotherham
force-pushed
the
component-search-input
branch
from
93755c9 to
9561a2f
Compare
colinrotherham
force-pushed
the
component-search-input
branch
from
1a6ce96 to
36fce83
Compare
colinrotherham
force-pushed
the
component-search-input-header
branch
from
5465b70 to
c15cec9
Compare
colinrotherham
force-pushed
the
component-search-input
branch
from
36fce83 to
42fb80e
Compare
colinrotherham
force-pushed
the
component-search-input-header
branch
from
c15cec9 to
3b36ce9
Compare
colinrotherham
force-pushed
the
component-search-input
branch
from
42fb80e to
3bf1e68
Compare
colinrotherham
force-pushed
the
component-search-input-header
branch
from
3b36ce9 to
bdd535e
Compare
colinrotherham
force-pushed
the
component-search-input
branch
2 times, most recently
from
8aba022 to
c889e76
Compare
colinrotherham
force-pushed
the
component-search-input-header
branch
from
bdd535e to
22ec60a
Compare
colinrotherham
force-pushed
the
component-search-input
branch
from
c889e76 to
fbebb23
Compare
colinrotherham
force-pushed
the
component-search-input-header
branch
from
22ec60a to
00796e0
Compare
colinrotherham
force-pushed
the
component-search-input
branch
2 times, most recently
from
ff1f76f to
3c7523c
Compare
colinrotherham
force-pushed
the
component-search-input-header
branch
from
00796e0 to
2d8facb
Compare
colinrotherham
changed the title
colinrotherham
changed the title
colinrotherham
force-pushed
the
component-search-input
branch
from
3c7523c to
ea8b3db
Compare
colinrotherham
force-pushed
the
component-search-input-header
branch
from
2d8facb to
39410a0
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates the header search to the search input component, added in:
Checklist