Select enhancement - enable width options#1776
Open
frankieroberto wants to merge 1 commit intoselect-enhancementsfrom
Open
Select enhancement - enable width options#1776frankieroberto wants to merge 1 commit intoselect-enhancementsfrom
frankieroberto wants to merge 1 commit intoselect-enhancementsfrom
Conversation
This allows the width to be set on selects, which would then also be used on the javascript-enhanced selects.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a quick experiment to enhance #1700 by also allowing some custom widths to be set.
Right now the select is always intrinsically sized based on content, but in #1700 it always has
width: 100%.I suspect there will remain a need to have smaller sizes.
The code in this PR lets you set
classes: 'nhsuk-select--width-20', and then that class is copied to the wrapper class with javascript and transformed intonhsuk-select-wrapper--width-20.This would mean that the width would apply to both no-js and the js-enhanced versions.
Currently I’ve only added 10, 20 and 30 size classes, rather than all the ones
inputsupports.