[v10] Close header menu when clicking or navigating elsewhere#1780
Open
colinrotherham wants to merge 7 commits intoheader-resize-observerfrom
Open
[v10] Close header menu when clicking or navigating elsewhere#1780colinrotherham wants to merge 7 commits intoheader-resize-observerfrom
colinrotherham wants to merge 7 commits intoheader-resize-observerfrom
Conversation
colinrotherham
added
javascript
colinrotherham
changed the title
colinrotherham
force-pushed
the
header-auto-close
branch
from
6bc9777 to
af44aa6
Compare
|
Contributor
|
Tested as much as I can, not having an SPA, works nicely. Esc key works too, not sure why it's struck out in your list? |
Contributor
Author
Ah sorry, because we already shipped it ages ago 😎 |
Contributor
Author
|
Thanks 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances the header component to automatically close when:
Pressing escapeThese changes ensure the menu isn't stuck open when a Single Page Application (SPA) swaps page content
Checklist