Change secondary border colour to "grey-3" and remove deprecated hover border colour#1826
Open
colinrotherham wants to merge 3 commits intosupport/10.xfrom
Open
Change secondary border colour to "grey-3" and remove deprecated hover border colour#1826colinrotherham wants to merge 3 commits intosupport/10.xfrom
colinrotherham wants to merge 3 commits intosupport/10.xfrom
Conversation
colinrotherham
changed the title
$nhsuk-reverse-border-colour for reverse borders$nhsuk-reverse-border-colour with deprecations
colinrotherham
force-pushed
the
secondary-border-colour
branch
from
c2af618 to
905f49a
Compare
Contributor
|
Nice thank you. Yes, I think although minor, it'll change things for people currently using |
Contributor
Author
As in, this is a breaking change? |
Contributor
|
Yes, but let's mark as deprecated. |
Contributor
Author
Brill. We can make #1788 v11 only |
colinrotherham
changed the title
$nhsuk-reverse-border-colour with deprecations$nhsuk-secondary-border-colour to hexadecimal
colinrotherham
changed the base branch from
support/10.x
to
reverse-border-colour
colinrotherham
force-pushed
the
secondary-border-colour
branch
from
905f49a to
df52338
Compare
colinrotherham
force-pushed
the
reverse-border-colour
branch
2 times, most recently
from
14cd707 to
7c2d0b7
Compare
colinrotherham
force-pushed
the
secondary-border-colour
branch
from
df52338 to
0c394ce
Compare
colinrotherham
force-pushed
the
reverse-border-colour
branch
from
7c2d0b7 to
72d6fd9
Compare
colinrotherham
force-pushed
the
secondary-border-colour
branch
from
0c394ce to
b953add
Compare
colinrotherham
force-pushed
the
secondary-border-colour
branch
from
b953add to
4da04c9
Compare
|
colinrotherham
changed the title
$nhsuk-secondary-border-colour to hexadecimal
colinrotherham
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes
$nhsuk-secondary-border-colourto "grey-3"#aeb7bdThe deprecated
$nhsuk-border-hover-colourvariable has also been removedAll palette colours are now hexadecimal for compatibility with GOV.UK Frontend v6 changes
Checklist